Add Armor json data #9 #33
Conversation
data/WOTC_5e_SRD_v5.1/armor.json
Outdated
| "ac": 14, | ||
| "cost": "400 gp", | ||
| "weight": "20 lb.", | ||
| "modifier": [ "dexterity" ], |
There was a problem hiding this comment.
On these guys I think this is supposed to be dex (max 2). Is there any way to indicate that here?
There was a problem hiding this comment.
what do you think about
"modifier_max": 2or
"modifier": [ { "ability": "dexterity", "max": 2 } ],
"modifier": [ { "ability": "dexterity", "max": null } ], // when no maxThere was a problem hiding this comment.
This is the code to calculate ac using that data source
https://github.com/gbalbuena/dndcli/blob/master/src/core/index.js#L19-L67
|
Hey guys, just so you know, I took this general file and after building a model and import process that would work, I adjusted it (quite a bit actually). You can see my work over in PR #38. Technically that work completely supercedes this PR, but it absolutely was based on this file. |
Good work!, we haven't finalize the structure, I'm about to send and update around the structure of the data based on @eepMoody comments |
|
please let me know if any change is required to merge this, so far I'm using it for my ac formulas and It's working as expected, you might need to do changes for your requirements or keep it as it is, we can always change and adapt |
|
@eepMoody Legendary! ⚔️ |
This is the armor json file that I'm using to calculate ac, was thinking could be valuable with some corrections.