Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding tob1 2024 monsters #426

Merged
merged 15 commits into from
Apr 10, 2024
Merged

Adding tob1 2024 monsters #426

merged 15 commits into from
Apr 10, 2024

Conversation

mshea
Copy link
Collaborator

@mshea mshea commented Mar 28, 2024

Sorry, this branch is mislabeled as TOB 3 but it's actually TOB 1 2023 monsters. I spent a bunch of time parsing TOB 1 2023 monsters and I've checked them pretty thoroughly. I think they're ready to merge.

mshea and others added 14 commits March 22, 2024 18:12
First push of TOB1 2024 monsters. Still messy but getting closer.
A bunch of monsters had some small errors. I fixed them. More fixes on the way.
Fixed spellcasting action blocks. Added some other null values.
Fixed speed JSON entries.
Page numbers added through fuzzywuzzy searches against a csv of page numbers pulled from the book.
had at least one weird space in a name that screwed up sorting. Fixed!
Fixed extra periods in special abilities, spellcasting blocks for some spellcasters, and added creature-specific legendary action descriptions.
It's actually a typo on the book itself! The spellcasting section of the mirror hag refers to it as a blood hag.
Actions werent' separating from legendary actions when a monster only had actions and legendary actions but not bonus or reactions. Fixed.
Some dumb monsters had multiple breath weapons that had to be handled separately.
@calumbell
Copy link
Contributor

calumbell commented Mar 29, 2024

Hi, thanks for your work getting these monsters input and formatted!

I encountered a few problems when I tried to build the database on my local branch. I have fixed them to the point that the server builds successfully, but isn't passing all the tests yet (will look into this tomorrow). I have pushed my changes to this PR.

  1. Certains fields in the Monster model (bonus_actions_json, reactions_json, legendary_desc, legendary_actions_json) were not nullable, so setting their value to null in Monsters.json was causing Django to choke.
    This was fixed by updating the Monster modal to accept null values for these, which is probably how it should have worked to start with (other sources handle the null value as either an empty string or "null" as a string, which seems weird to me)

  2. The document field in the Monster.json file is supposed to contain the primary key (pk) of that monster's source document. For TOB-2023, that value is 47 (as defined in data/v1/tob-2023/Document.json). I fixed this by updating the value of the document field for all the monsters you've added.

@calumbell calumbell requested a review from augustjohnson March 30, 2024 08:49
@augustjohnson
Copy link
Collaborator

New fields in the data, but not yet exposed in the API... we should make sure we're going in open-eyed to that change. I'm considering that out-of-scope at the moment.

@calumbell calumbell merged commit 81d551b into staging Apr 10, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants