Query Monsters by size and hit points #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calumbell
approved these changes
Jul 20, 2024
There was a problem hiding this comment.
Looks good, works great on local! Query params on the endpoints /monsters/?ordering=size, /monsters/?ordering=-size ,/monsters/?ordering=hit_points, /monsters/?ordering=-hit_points return sorted results as expected. Nothing breaks and tests pass.
One small weirdness is that ordering by size doesn’t actually order by how large a monster is (tiny → small → medium → large) but by how the names of these size catagories sort alphabetically (garganutan → … → titanic). I believe this issue is already being addressed in API V2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These fields were not searchable. This created a problem for the new Pagination feature for the Open5e site, which now relies on the API for filtering.