Bugfix (API V2): Added missing Serializers to CreatureSerializer
#603
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where the
environments
andlanguages
fields of the/creatures
endpoint could not be filtered via query parameter.eg.
v2/creature/?environment__fields=name
andv2/creature/?languages__field=name
had no effect on the API response.This was because the
LanguageSerializer
andEnvironmentSerializer
were not included on theCreatureSerializer
, so these fields did not correctly inherit the logic defined in theGameContentSerializer
abstract class for managing filtering nested fields.Now, the query parameters for a creature of the form
/?fields=languages,environments&languages__fields=name&environments__fields=name
will generate a response of the form: