Enable pause when initialize load #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hisatake
reviewed
Jul 1, 2017
| @@ -326,6 +326,7 @@ public void setRepeatModifier(final boolean repeat) { | |||
| public void setPausedModifier(final boolean paused) { | |||
|
|
|||
| mPaused = paused; | |||
| mActiveStatePauseStatus = paused; | |||
There was a problem hiding this comment.
// not async to prevent random crashes on Android playback from local resource due to race conditions
↑のコメントが書いてるのを加味してもasync で大丈夫っすかね？
There was a problem hiding this comment.
@hisatake
あ、これもう一個のPRの方に対してのコメントですかね
https://open8.docbase.io/posts/244635?list=%2F&q=#-prepareasync
軽く調べたんですけど、公式のドキュメントにストリームだったらprepareAsyncを使うように書いてあるので問題ないかなあと思っています
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix paused prop doesn't work when init the Video
TheWidlarzGroup#625