Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Golang to 1.22 #557

Merged
merged 1 commit into from
Feb 28, 2024
Merged

Update Golang to 1.22 #557

merged 1 commit into from
Feb 28, 2024

Conversation

mpass99
Copy link
Collaborator

@mpass99 mpass99 commented Feb 27, 2024

It is considering the last Update of Golang (2f43bce) and the changes that make the separate handling in the GitHub CI obsolete (39fc0f9).

@mpass99 mpass99 self-assigned this Feb 27, 2024
@mpass99 mpass99 requested a review from MrSerth February 27, 2024 15:46
Copy link

codecov bot commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.12%. Comparing base (ab938bf) to head (2daa6a7).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #557      +/-   ##
==========================================
- Coverage   77.59%   77.12%   -0.47%     
==========================================
  Files          39       41       +2     
  Lines        3316     3489     +173     
==========================================
+ Hits         2573     2691     +118     
- Misses        545      586      +41     
- Partials      198      212      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@MrSerth MrSerth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking a look here. In general, the upgrade looks fine, but I still struggle to work with the Go dependency files (two recent questions detailed below).

go.mod Outdated Show resolved Hide resolved
go.mod Show resolved Hide resolved
go.mod Show resolved Hide resolved
MrSerth
MrSerth previously approved these changes Feb 27, 2024
Copy link
Member

@MrSerth MrSerth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, ready to merge.

@mpass99 mpass99 merged commit d5ac270 into main Feb 28, 2024
12 checks passed
@mpass99 mpass99 deleted the refactor/golang branch February 28, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants