Fixes #1559: Added internet connectivity check before loading client info

mifosng-android/src/instrumentTest/java/com/mifos/mifosxdroid/tests/ClientChargesTest.java

@@ -16,7 +16,6 @@
 import com.mifos.mifosxdroid.dialogfragments.chargedialog.ChargeDialogFragment;
 import com.mifos.mifosxdroid.online.ClientActivity;
 import com.mifos.mifosxdroid.online.clientcharge.ClientChargeFragment;
-import com.mifos.mifosxdroid.online.clientdetails.ClientDetailsFragment;
 import com.mifos.utils.Constants;
 
 import static androidx.test.espresso.Espresso.onView;

mifosng-android/src/instrumentTest/java/com/mifos/mifosxdroid/tests/ClientDetailsFragmentTest.java

@@ -14,7 +14,6 @@
 
 import com.mifos.mifosxdroid.R;
 import com.mifos.mifosxdroid.online.ClientActivity;
-import com.mifos.mifosxdroid.online.clientdetails.ClientDetailsFragment;
 import com.mifos.utils.Constants;
 import com.mifos.utils.FragmentConstants;
 

mifosng-android/src/main/java/com/mifos/mifosxdroid/injection/component/ActivityComponent.java

@@ -23,6 +23,7 @@
 import com.mifos.mifosxdroid.online.collectionsheetindividualdetails.IndividualCollectionSheetDetailsFragment;
 import com.mifos.mifosxdroid.online.collectionsheetindividual.NewIndividualCollectionSheetFragment;
 import com.mifos.mifosxdroid.online.collectionsheetindividualdetails.PaymentDetailsFragment;
+import com.mifos.mifosxdroid.online.clientdetails.ClientDetailsFragment;
 import com.mifos.mifosxdroid.online.runreports.report.ReportFragment;
 import com.mifos.mifosxdroid.online.runreports.reportcategory.ReportCategoryFragment;
 import com.mifos.mifosxdroid.online.runreports.reportdetail.ReportDetailFragment;
@@ -37,7 +38,6 @@
 import com.mifos.mifosxdroid.online.activate.ActivateFragment;
 import com.mifos.mifosxdroid.online.centerdetails.CenterDetailsFragment;
 import com.mifos.mifosxdroid.online.clientcharge.ClientChargeFragment;
-import com.mifos.mifosxdroid.online.clientdetails.ClientDetailsFragment;
 import com.mifos.mifosxdroid.online.clientidentifiers.ClientIdentifiersFragment;
 import com.mifos.mifosxdroid.online.clientlist.ClientListFragment;
 import com.mifos.mifosxdroid.online.collectionsheet.CollectionSheetFragment;

mifosng-android/src/main/java/com/mifos/mifosxdroid/online/clientdetails/ClientDetailsFragment.kt

@@ -6,10 +6,12 @@ package com.mifos.mifosxdroid.online.clientdetails
 
 import android.Manifest
 import android.app.Activity
+import android.content.Context
 import android.content.Intent
 import android.content.pm.PackageManager
 import android.graphics.Bitmap
 import android.graphics.BitmapFactory
+import android.net.ConnectivityManager
 import android.net.Uri
 import android.os.Bundle
 import android.os.Environment
@@ -174,7 +176,15 @@ class ClientDetailsFragment : MifosBaseFragment(), ClientDetailsMvpView {
     }
 
     fun inflateClientInformation() {
-        mClientDetailsPresenter!!.loadClientDetailsAndClientAccounts(clientId)
+        val context = context
+        val systemService = context!!.getSystemService(Context.CONNECTIVITY_SERVICE)
+        val connectivityManager = systemService as ConnectivityManager
+        val networkInfo = connectivityManager.activeNetworkInfo
+        if (networkInfo != null && networkInfo.isConnected) {
+            mClientDetailsPresenter!!.loadClientDetailsAndClientAccounts(clientId)
+            return
+        }
+        showFetchingError(getString(R.string.device_not_connected_to_internet))
     }
 
     override fun onAttach(activity: Activity) {

mifosng-android/src/main/java/com/mifos/mifosxdroid/online/clientdetails/ClientDetailsPresenter.kt

@@ -1,7 +1,9 @@
 package com.mifos.mifosxdroid.online.clientdetails
 
+import com.mifos.App
 import com.mifos.api.datamanager.DataManagerClient
 import com.mifos.api.datamanager.DataManagerDataTable
+import com.mifos.mifosxdroid.R
 import com.mifos.mifosxdroid.base.BasePresenter
 import com.mifos.objects.zipmodels.ClientAndClientAccounts
 import okhttp3.MediaType
@@ -98,7 +100,8 @@ class ClientDetailsPresenter @Inject constructor(private val mDataManagerDataTab
                     override fun onCompleted() {}
                     override fun onError(e: Throwable) {
                         mvpView!!.showProgressbar(false)
-                        mvpView!!.showFetchingError("Client not found.")
+                        val msg = App.getContext().getString(R.string.client_not_found)
+                        mvpView!!.showFetchingError(msg)
                     }
 
                     override fun onNext(clientAndClientAccounts: ClientAndClientAccounts?) {

mifosng-android/src/main/res/values-ca/strings.xml

@@ -166,4 +166,7 @@
 
     <string name="accounts">Comptes</string>
 
+    <string name="client_not_found">No s\'ha trobat el client.</string>
+    <string name="device_not_connected_to_internet">Dispositiu no connectat a Internet</string>
+
 </resources>

mifosng-android/src/main/res/values-en/strings.xml

@@ -189,5 +189,8 @@
     <string name="surveyEmpty">This Survey is Empty</string>
     <string name="accounts">Accounts</string>
 
+    <string name="client_not_found">Client not found.</string>
+    <string name="device_not_connected_to_internet">Device not connected to internet</string>
+
 
 </resources>

mifosng-android/src/main/res/values-es/strings.xml

@@ -166,4 +166,7 @@
 
     <string name="accounts">cuenta</string>
 
+    <string name="client_not_found">Cliente no encontrado.</string>
+    <string name="device_not_connected_to_internet">Dispositivo no conectado a internet</string>
+
 </resources>

mifosng-android/src/main/res/values-fr/strings.xml

@@ -612,4 +612,7 @@
 
     <string name="accounts">Compte</string>
 
+    <string name="client_not_found">Client introuvable.</string>
+    <string name="device_not_connected_to_internet">Appareil non connecté à Internet</string>
+
 </resources>

mifosng-android/src/main/res/values-hi/strings.xml

@@ -616,6 +616,9 @@
     <string name="due_collection">कलेक्शन का देय</string>
     <string name="accounts">खाता</string>
 
+    <string name="client_not_found">ग्राहक नहीं मिला।</string>
+    <string name="device_not_connected_to_internet">डिवाइस इंटरनेट से कनेक्ट नहीं है</string>
+
     !-- About App -->
     <string name="about_app">फील्ड ऑफिसर एप्लीकेशन एक एप्लीकेशन है बैंक स्टाफ फील्ड ऑफिसर के लिए विकसित किया गया
          ग्राहकों का केंद्र, समूह, ऋण खाता, बचत खाता, आदि।ट्रैक रखने के लिए </string>

mifosng-android/src/main/res/values-kn/strings.xml

@@ -596,4 +596,7 @@
 
     <string name="accounts">ಖಾತೆ</string>
 
+    <string name="client_not_found">ಗ್ರಾಹಕ ಕಂಡುಬಂದಿಲ್ಲ.</string>
+    <string name="device_not_connected_to_internet">ಸಾಧನ ಇಂಟರ್ನೆಟ್‌ಗೆ ಸಂಪರ್ಕಗೊಂಡಿಲ್ಲ</string>
+
 </resources>

mifosng-android/src/main/res/values-sw/strings.xml

@@ -724,6 +724,9 @@
     <string name="browse">Vinjari</string>
     <string name="accounts">akaunti</string>
 
+    <string name="client_not_found">Mteja hajapatikana.</string>
+    <string name="device_not_connected_to_internet">Kifaa hakijaunganishwa kwenye mtandao</string>
+
     <!-- Language -->
     <string name="language">Lugha</string>
     <string name="language_type" translatable="false">language_type</string>

mifosng-android/src/main/res/values-zh/strings.xml

@@ -713,6 +713,9 @@
     <string name="error_passcode">密码应该是4位数</string>
     <string name="accounts">帳戶</string>
 
+    <string name="client_not_found">找不到客户端。</string>
+    <string name="device_not_connected_to_internet">设备未连接到互联网</string>
+
     <!-- Language -->
     <string name="language">语</string>
     <string name="language_type" translatable="false">language_type</string>

mifosng-android/src/main/res/values/strings.xml

@@ -914,4 +914,7 @@
 
     <string name="instance_url">Instance Url</string>
 
+    <string name="client_not_found">Client not found.</string>
+    <string name="device_not_connected_to_internet">Device not connected to internet</string>
+
 </resources>