Migrate search fragment to compose UI #2108
Open
+1,542
−560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # mifosng-android/build.gradle.kts # mifosng-android/src/main/java/com/mifos/mifosxdroid/online/search/SearchFragment.kt # mifosng-android/src/main/java/com/mifos/mifosxdroid/online/search/SearchUiState.kt # mifosng-android/src/main/java/com/mifos/mifosxdroid/online/search/SearchViewModel.kt # mifosng-android/src/test/java/com/mifos/viewmodels/SearchViewModelTest.kt
# Conflicts: # mifosng-android/build.gradle.kts
…llectAsStateWithLifecycle
…llectAsStateWithLifecycle
…to MIFOSAC-168-migrate-search-fragment-to-compose # Conflicts: # mifosng-android/build.gradle.kts # mifosng-android/src/main/java/com/mifos/mifosxdroid/online/search/SearchViewModel.kt # mifosng-android/src/test/java/com/mifos/viewmodels/SearchViewModelTest.kt
- Moved files to specific package - Created new search module - Fixed search screen UX/UI
niyajali
changed the title
|
@therajanmaurya @Aditya-gupta99 pls review this pr |
Aditya-gupta99
requested changes
Jun 9, 2024
Comment on lines
+10
to
+23
| // @Mock | ||
| // lateinit var searchRepository: SearchRepository | ||
| // | ||
| // private lateinit var searchViewModel: SearchViewModel | ||
| // | ||
| // private val dispatcher: TestDispatcher = StandardTestDispatcher() | ||
| // | ||
| // @OptIn(ExperimentalCoroutinesApi::class) | ||
| // @Before | ||
| // fun setUp() { | ||
| // MockitoAnnotations.openMocks(this) | ||
| // searchViewModel = SearchViewModel(searchRepository) | ||
| // Dispatchers.setMain(dispatcher) | ||
| // } |
There was a problem hiding this comment.
Why you have commented this code ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes MIFOSAC-168
Please Add Screenshots If there are any UI changes.
screen-20240605-225004.mp4
Please make sure these boxes are checked before submitting your pull request - thanks!
Apply the
MifosStyle.xmlstyle template to your code in Android Studio.Run the unit tests with
./gradlew checkto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.