Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app introduction implemented #1271

Closed

Conversation

devansh-299
Copy link
Contributor

Feature : Application Introduction screens

Screen Recording

GIF-200118_174940

Suggestions

  • Please suggest changes for the strings and color scheme etc (if needed)
  • Please suggest if any animations should be added or not

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Apply the AndroidStyle.xml style template to your code in Android Studio.

  • Run the unit tests with ./gradlew check to make sure you didn't break anything

  • If you have multiple commits please combine them into one commit by squashing them.

@laxyapahuja
Copy link
Contributor

It is advised to make an issue first and then send a PR.

@laxyapahuja
Copy link
Contributor

Have you tested this so that it doesn't appear every time a user opens the app?

@devansh-299
Copy link
Contributor Author

It is advised to make an issue first and then send a PR.

Yeah, I will keep this in mind

@devansh-299
Copy link
Contributor Author

Have you tested this so that it doesn't appear every time a user opens the app?

Yes

@OHassini
Copy link
Contributor

@devansh-299 Make sure you only include changes related to your issue, remove all the extra build gradle and manifest changes.

@devansh-299
Copy link
Contributor Author

@devansh-299 Make sure you only include changes related to your issue, remove all the extra build gradle and manifest changes.

I tried updating the PR but these changes are introduced on their on own while committing

@rchtgpt
Copy link
Member

rchtgpt commented Jan 29, 2020

I tried updating the PR but these changes are introduced on their on own while committing

Changes are not introduced automatically while committing. Though there is a possibility that syncing the gradle does some reformatting. You will have to manually remove the formatted lines of code if you want your PR to be merged.

@devansh-299
Copy link
Contributor Author

I tried updating the PR but these changes are introduced on their on own while committing

Changes are not introduced automatically while committing. Though there is a possibility that syncing the gradle does some reformatting. You will have to manually remove the formatted lines of code if you want your PR to be merged.

I don't know how it happened, but yeah I will try to resolve it

@devansh-299
Copy link
Contributor Author

@Rachittt I have updated the PR with an associated issue #1473

@rutvik-panchal
Copy link
Contributor

@devansh-299 We can use viewPager2 and RecyclerViewAdapter to implement the app introduction and use only one layout for the implementation.

@devansh-299
Copy link
Contributor Author

@devansh-299 We can use viewPager2 and RecyclerViewAdapter to implement the app introduction and use only one layout for the implementation.

@rutvik-panchal thanks for the update. It's an old PR and I have really lost the track of it. I
will check and get back to you :)

@luckyman20
Copy link
Collaborator

Old PR. Fixed in PR #2070.

@luckyman20 luckyman20 closed this Jun 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants