-
Notifications
You must be signed in to change notification settings - Fork 670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
app introduction implemented #1271
Conversation
4983ba4
to
d5d9f91
Compare
It is advised to make an issue first and then send a PR. |
Have you tested this so that it doesn't appear every time a user opens the app? |
Yeah, I will keep this in mind |
Yes |
@devansh-299 Make sure you only include changes related to your issue, remove all the extra build gradle and manifest changes. |
I tried updating the PR but these changes are introduced on their on own while committing |
Changes are not introduced automatically while committing. Though there is a possibility that syncing the gradle does some reformatting. You will have to manually remove the formatted lines of code if you want your PR to be merged. |
I don't know how it happened, but yeah I will try to resolve it |
d5d9f91
to
1b71d61
Compare
1b71d61
to
9252db4
Compare
@devansh-299 We can use viewPager2 and RecyclerViewAdapter to implement the app introduction and use only one layout for the implementation. |
@rutvik-panchal thanks for the update. It's an old PR and I have really lost the track of it. I |
Old PR. Fixed in PR #2070. |
Feature : Application Introduction screens
Screen Recording
Suggestions
Please make sure these boxes are checked before submitting your pull request - thanks!
Apply the
AndroidStyle.xml
style template to your code in Android Studio.Run the unit tests with
./gradlew check
to make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.