You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR includes codes not related to what is written in its title. It would be best to create new branches for each issue from the origin/openMF/development branch and also each PR should contain the changes/solution for the issue which has been linked not more than that.
No, I don't think saving data objects in the shared preferences is a good idea as it is described in the description of the issue, because shared preferences are intended to be used to save small data in key-value formats. To support a proper offline first approach we would need to use a database that is out of scope at the moment.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PratyushSingh07
force-pushed
the
optional-support
branch
2 times, most recently
from
Fixes #1122
Before the Change:
https://user-images.githubusercontent.com/90026952/223648417-cabed712-84ce-4d88-aa56-5b2e7f06d48b.mp4
After the Change:
WhatsApp.Video.2023-03-08.at.12.51.26.mp4
Apply the
AndroidStyle.xmlstyle template to your code in Android Studio.Run the unit tests with
./gradlew checkto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.