safe way to collect flows from android UI #2550
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MuindiStephen
commented
Mar 26, 2024
| @@ -2,6 +2,7 @@ package org.mifos.mobile.utils | |||
|
|
|||
| import android.graphics.Bitmap | |||
| import org.mifos.mobile.models.client.Client | |||
| import org.mifos.mobile.ui.user_profile.UserDetails | |||
| @@ -10,3 +11,11 @@ sealed class UserDetailUiState { | |||
| data class ShowUserDetails(val client: Client) : UserDetailUiState() | |||
| data class ShowUserImage(val image: Bitmap?) : UserDetailUiState() | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Ignore this class, just that its another way to declare ui state
therajanmaurya
requested changes
Apr 7, 2024
| var error: String? = null, | ||
| var allUserDetails: List<Client> = listOf() | ||
| ) | ||
| */ |
There was a problem hiding this comment.
remove this unused code block.
There was a problem hiding this comment.
remove this unused code block.
Yes. Looking into that.
MuindiStephen
commented
Apr 8, 2024
| @@ -2,6 +2,7 @@ package org.mifos.mobile.utils | |||
|
|
|||
| import android.graphics.Bitmap | |||
| import org.mifos.mobile.models.client.Client | |||
| import org.mifos.mobile.ui.user_profile.UserDetails | |||
|
|
|||
|
|
|||
| sealed class UserDetailUiState { | |||
There was a problem hiding this comment.
To be removed, since unused block of code stmt.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The safest way to collecting flows from UI eg. HomeActivity
repeatOnLifecycle is a suspend function that takes a Lifecycle.State as a parameter which is used to automatically create and launch a new coroutine with the block passed to it when the lifecycle reaches that state, and cancel the ongoing coroutine that’s executing the block when the lifecycle falls below the state