Navigation drawer with client list added #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Navigation drawer with client list added Navigation drawer, Client list added error handling with some minor changes internal server error handled
| toolbar.setTitle(getString(R.string.home)); | ||
| } | ||
|
|
||
| replaceFragment(new ClientListFragment(), false, R.id.container); |
There was a problem hiding this comment.
Don't create fragments like this.
Use getInstance() method to create Fragments.
|
Please fix these problems and resend PR. |
Closed
akashmeruva9
pushed a commit
to akashmeruva9/mifos-mobile
that referenced
this pull request
Jul 5, 2024
# This is the 1st commit message: refactor: openMF#2636 Use MaterialTheme colors for a uniform theme (openMF#2637) # This is the commit message openMF#2: refactor: savings module (openMF#2635) # This is the commit message openMF#3: refactor: qr module (openMF#2638) # This is the commit message openMF#4: A migrate transfer process screen to compose screen openMF#2583 (openMF#2585) refactor: qr code display migration (openMF#2609) Migrate Beneficiary List from XML to compose (openMF#2607) "Added MIfos Logo to RegistrationScreen" (openMF#2613) * Added Image to RegistrationScreen * "Added Image to RegistrationScreen" Bug: Resolved Swipe Refresh Not Working in RecentTransaction Screen Compose (openMF#2617) * "Resolved Swipe Refresh Not Working" * Resolved Swipe Refresh Not Working * Centered the Swipe Refresh And Added Padding migrate saving accounts transaction screen to compose openMF#2588 (openMF#2596) * migrate saving accounts transaction screen to compose openMF#2588 * Update SavingAccountsTransactionTopBar.kt * init * init * refactor: savings accounts screen migration * refactor: savings accounts screen migration --------- Co-authored-by: Avneet Singh <avneetmaankiya@gmail.com> fix#2615 Missing TopAppBar navigation back implementation in AddBeneficiaryScreen (openMF#2616) fix#2610: Scrolling Disabled in TransferProcessFragment (openMF#2611) fix#2610: Scrolling Disabled in TransferProcessFragment fix#2610: Scrolling Disabled in TransferProcessFragment Beneficiary application (openMF#2618) Settings screen migration (openMF#2619) refactor: Registration Module # This is the commit message openMF#5: refactor: Login module # This is the commit message openMF#6: refactor: Login module # This is the commit message openMF#7: refactor: Recent Login module # This is the commit message openMF#8: A migrate transfer process screen to compose screen openMF#2583 (openMF#2585) refactor: qr code display migration (openMF#2609) Migrate Beneficiary List from XML to compose (openMF#2607) "Added MIfos Logo to RegistrationScreen" (openMF#2613) * Added Image to RegistrationScreen * "Added Image to RegistrationScreen" Bug: Resolved Swipe Refresh Not Working in RecentTransaction Screen Compose (openMF#2617) * "Resolved Swipe Refresh Not Working" * Resolved Swipe Refresh Not Working * Centered the Swipe Refresh And Added Padding migrate saving accounts transaction screen to compose openMF#2588 (openMF#2596) * migrate saving accounts transaction screen to compose openMF#2588 * Update SavingAccountsTransactionTopBar.kt * init * init * refactor: savings accounts screen migration * refactor: savings accounts screen migration --------- Co-authored-by: Avneet Singh <avneetmaankiya@gmail.com> fix#2615 Missing TopAppBar navigation back implementation in AddBeneficiaryScreen (openMF#2616) fix#2610: Scrolling Disabled in TransferProcessFragment (openMF#2611) fix#2610: Scrolling Disabled in TransferProcessFragment fix#2610: Scrolling Disabled in TransferProcessFragment Beneficiary application (openMF#2618) Settings screen migration (openMF#2619) refactor: Registration Module # This is the commit message openMF#9: refactor: Login module refactor: Login module refactor: Recent Login module refactor: transfer process module (openMF#2644)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains: