Fix #13 : Wrong Passcode Dot Issue #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miPlodder
commented
Jun 4, 2018
app/build.gradle
Outdated
| @@ -24,6 +24,6 @@ dependencies { | |||
| testImplementation 'junit:junit:4.12' | |||
| androidTestImplementation 'com.android.support.test:runner:1.0.1' | |||
| androidTestImplementation 'com.android.support.test.espresso:espresso-core:3.0.1' | |||
| // implementation project(':mifos-passcode') | |||
| implementation project(':mifos-passcode') | |||
There was a problem hiding this comment.
@therajanmaurya Commanding this line was causing crash on start-up.
There was a problem hiding this comment.
yeah got it, remove the below line implementation 'com.mifos.mobile:mifos-passcode:0.3.0' and stay with the above.
3 tasks
therajanmaurya
requested changes
Jun 11, 2018
app/build.gradle
Outdated
| @@ -24,6 +24,6 @@ dependencies { | |||
| testImplementation 'junit:junit:4.12' | |||
| androidTestImplementation 'com.android.support.test:runner:1.0.1' | |||
| androidTestImplementation 'com.android.support.test.espresso:espresso-core:3.0.1' | |||
| // implementation project(':mifos-passcode') | |||
| implementation project(':mifos-passcode') | |||
There was a problem hiding this comment.
yeah got it, remove the below line implementation 'com.mifos.mobile:mifos-passcode:0.3.0' and stay with the above.
|
@therajanmaurya I have made the changes, please review it again. |
|
@therajanmaurya I don't why this Travis build is failing, but passing on my local machine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.