feat: added data table for transactions of saving account #1844
Conversation
Now we can add the data table for transactions entity type of saving account and also we can edit,delete and create the datatable. Fixes: openMF#1726
|
@ramvr1256 @luckyman20 could you please help in reviewing this PR? |
There was a problem hiding this comment.
Please keep an eye on how you comment. The logic seems fine.
@bharathcgowda I hope this is tested.
Tests are failing as well, please see to that.
| import { Injectable } from '@angular/core'; | ||
| import { Resolve, ActivatedRouteSnapshot } from '@angular/router'; | ||
|
|
||
| //rxjs Imports |
There was a problem hiding this comment.
| //rxjs Imports | |
| // rxjs Imports |
| import { Injectable } from '@angular/core'; | ||
| import { Resolve, ActivatedRouteSnapshot } from '@angular/router'; | ||
|
|
||
| //rxjs Imports |
There was a problem hiding this comment.
| //rxjs Imports | |
| // rxjs Imports |
| /** | ||
| * | ||
| * @param route | ||
| * @returns {Observable<any>} |
There was a problem hiding this comment.
| * @returns {Observable<any>} | |
| * @returns {Observable<boolean>} |
There was a problem hiding this comment.
Actually below should be any
There was a problem hiding this comment.
Can you please elaborate?
| }) | ||
|
|
||
| export class DatatableTransactionTabComponent implements OnInit { | ||
| entityId: string; |
There was a problem hiding this comment.
Need comment for this variable as well.
| }); | ||
| } | ||
|
|
||
| ngOnInit(): void { |
There was a problem hiding this comment.
Is it required if it is empty?
There was a problem hiding this comment.
No, it is not required I can remove it, actually when we generate a component in angular this comes automatically.
There was a problem hiding this comment.
I can remove it too.
| children:[{ | ||
| path:':datatableName', | ||
| component:DatatableTransactionTabComponent, | ||
| data: {title : extract('View Data table'),routeParamBreadcrumb:'datatableName'}, |
There was a problem hiding this comment.
| data: {title : extract('View Data table'),routeParamBreadcrumb:'datatableName'}, | |
| data: {title : extract('View Data table'), routeParamBreadcrumb:'datatableName'}, |
| path: 'datatables', | ||
| children:[{ | ||
| path:':datatableName', | ||
| component:DatatableTransactionTabComponent, |
There was a problem hiding this comment.
| component:DatatableTransactionTabComponent, | |
| component: DatatableTransactionTabComponent, |
| { | ||
| path: 'datatables', | ||
| children:[{ | ||
| path:':datatableName', |
There was a problem hiding this comment.
| path:':datatableName', | |
| path: ':datatableName', |
| @@ -6,6 +6,7 @@ export const appTableData: { displayValue: string, value: string }[] = [ | |||
| { displayValue: 'Loan Account', value: 'm_loan' }, | |||
| { displayValue: 'Saving Account', value: 'm_savings_account' }, | |||
| { displayValue: 'Loan Product', value: 'm_product_loan' }, | |||
| {displayValue: 'Saving Account Transaction',value: 'm_savings_account_transaction'}, | |||
There was a problem hiding this comment.
| {displayValue: 'Saving Account Transaction',value: 'm_savings_account_transaction'}, | |
| { displayValue: 'Saving Account Transaction', value: 'm_savings_account_transaction' }, |
|
|
||
| /** | ||
| * | ||
| * @param savingsService |
There was a problem hiding this comment.
| * @param savingsService | |
| * @param savingsService Savings Service. |
|
@luckyman20 which tests are failing? |
I can see that task named 'Publish Image in Docker Hub / build (pull_request) has failed.' |
|
@luckyman20 docker hub test failing will not affect the code when it will be deployed, it will work fine docker hub is failing because it can't able to log in, I don't have the right to log in to the docker hub |
|
@bharathcgowda please merge it now. |
|
Thank you @luckyman20 for reviewing this properly and thank you @PC-11-00 for fixing all the comments. |
Description
Now we can add the data table for transactions entity type of saving account and also we can edit,delete and create the datatable.
Related issues and discussion
#1726
Screenshots, if any
transaction_datatable.mov
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
If you have multiple commits please combine them into one commit by squashing them.
Read and understood the contribution guidelines at
web-app/.github/CONTRIBUTING.md.