FINERACT-2107: Interest refund configuration for Progressive loan #2152

adamsaghy · 2024-07-23T10:50:15Z

Description

Describe the changes made and why they were made instead of how they were made. List any dependencies that are required for this change.

Related issues and discussion

#{Issue Number}

Screenshots, if any

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

If you have multiple commits please combine them into one commit by squashing them.
Read and understood the contribution guidelines at web-app/.github/CONTRIBUTING.md.

janez89 · 2024-07-23T10:54:21Z

src/app/products/loan-products/common/loan-product-summary/loan-product-summary.component.html

+  </div>
+
+  <div fxFlexFill *ngIf="isAdvancedPaymentAllocation && supportedInterestRefundTypes.length > 0">
+    <span fxFlex="47%">{{ 'labels.inputs.SUPPORTED INTEREST REFUND TYPES ' | translate}}:</span>


The space after the translation may not needed

somasorosdpc · 2024-07-23T11:57:43Z

src/assets/translations/lv-LV.json

-      "valid": "derīgs"
+      "valid": "derīgs",
+      "INTEREST REFUND": "INTEREST REFUND",
+      "SUPPORTED REFUND TRANSACTIONS FOR INTEREST REFUND": "Supported interest refund types"


You forgot to replace translation

alberto-art3ch

Please review the changes requested, and run the next command to review the TypeScript style:

npx tslint src/**/*.ts

Thanks

alberto-art3ch · 2024-07-23T14:35:59Z

...ucts/loan-product-stepper/loan-product-interest-refund-step/string-enum-option-data-model.ts

@@ -0,0 +1,5 @@
+export interface StringEnumOptionData {


Already exists an interface for that: OptionData in 'app/shared/models/option-data.model'

Its not the same. OptionData id is number. StringEnumOptionData id is string

alberto-art3ch · 2024-07-23T14:37:49Z

...t-stepper/loan-product-interest-refund-step/loan-product-interest-refund-step.component.html

+
+    <mat-form-field fxFlex="48%">
+      <mat-label>{{'labels.inputs.SUPPORTED INTEREST REFUND TYPES' | translate}}</mat-label>
+      <mat-select multiple formControlName="supportedInterestRefundTypes" matTooltip="{{ 'tooltips.Refund transactions where interest refund will automatically be calculated' | translate}}">


I'm not sure if the tooltip translate is already defined

Nice catch!

alberto-art3ch · 2024-07-23T14:38:52Z

src/app/products/loan-products/edit-loan-product/edit-loan-product.component.ts

@@ -115,6 +136,10 @@ export class EditLoanProductComponent implements OnInit {
    this.wasPaymentAllocationChanged = true;
  }

+  setSupportedInterestRefundTypes(supportedInterestRefundTypes: StringEnumOptionData[]): void {


Use the OptionData already defined in 'app/shared/models/option-data.model'

Its not the same. OptionData id is number. StringEnumOptionData id is string

alberto-art3ch · 2024-07-23T14:39:48Z

src/app/products/loan-products/common/loan-product-summary/loan-product-summary.component.ts

@@ -331,4 +339,8 @@ export class LoanProductSummaryComponent implements OnInit, OnChanges {
    return this.accounting.getAccountRuleName(value.toUpperCase());
  }

+  mapHumanReadableValueStringEnumOptionDataList(incomingParameter : StringEnumOptionData[]): string[] {


Use the OptionData already defined in 'app/shared/models/option-data.model'

Its not the same. OptionData id is number. StringEnumOptionData id is string

alberto-art3ch · 2024-07-23T14:40:16Z

src/app/products/loan-products/create-loan-product/create-loan-product.component.ts

@@ -99,6 +129,10 @@ export class CreateLoanProductComponent implements OnInit {
    this.creditAllocation = paymentAllocation;
  }

+  setSupportedInterestRefundTypes(supportedInterestRefundTypes: StringEnumOptionData[]): void {


Use the OptionData already defined in 'app/shared/models/option-data.model'

Its not the same. OptionData id is number. StringEnumOptionData id is string

alberto-art3ch · 2024-07-23T14:40:29Z

src/app/products/loan-products/create-loan-product/create-loan-product.component.ts

      });
  }

+  mapStringEnumOptionToIdList(incomingValues: StringEnumOptionData[]): string[] {


Use the OptionData already defined in 'app/shared/models/option-data.model'

Its not the same. OptionData id is number. StringEnumOptionData id is string

alberto-art3ch · 2024-07-23T14:40:54Z

src/app/products/loan-products/edit-loan-product/edit-loan-product.component.ts

@@ -175,4 +203,8 @@ export class EditLoanProductComponent implements OnInit {
      });
  }

+  mapStringEnumOptionToIdList(incomingValues: StringEnumOptionData[]): string[] {


Use the OptionData already defined in 'app/shared/models/option-data.model'

Its not the same. OptionData id is number. StringEnumOptionData id is string

alberto-art3ch · 2024-07-23T14:41:29Z

...uct-stepper/loan-product-interest-refund-step/loan-product-interest-refund-step.component.ts

+      });
+  }
+
+  mapStringEnumOptionToIdList(incomingValues: StringEnumOptionData[]): string[] {


Use the OptionData already defined in 'app/shared/models/option-data.model'

Its not the same. OptionData id is number. StringEnumOptionData id is string

alberto-art3ch · 2024-07-23T14:42:10Z

src/app/products/loan-products/models/loan-product.model.ts

@@ -125,6 +131,7 @@ export interface LoanProduct {
  feeToIncomeAccountMappings?:                               ChargeToIncomeAccountMapping[];
  penaltyToIncomeAccountMappings?:                           ChargeToIncomeAccountMapping[];
  enableAccrualActivityPosting?:                             boolean;
+  supportedInterestRefundTypes?:                             StringEnumOptionData[];


Use the OptionData already used here in this interface

Its not the same. OptionData id is number. StringEnumOptionData id is string

alberto-art3ch

LGTM

adamsaghy requested a review from josehernandezfintecheandomx July 23, 2024 10:50

janez89 reviewed Jul 23, 2024

View reviewed changes

adamsaghy force-pushed the FINERACT-2107/interest_refund_config branch from 285c75b to 1d3970f Compare July 23, 2024 11:02

somasorosdpc reviewed Jul 23, 2024

View reviewed changes

adamsaghy force-pushed the FINERACT-2107/interest_refund_config branch from 1d3970f to 3d903ab Compare July 23, 2024 11:59

alberto-art3ch requested changes Jul 23, 2024

View reviewed changes

adamsaghy force-pushed the FINERACT-2107/interest_refund_config branch 3 times, most recently from 6343152 to 457e76f Compare July 23, 2024 16:31

FINERACT-2107: Interest refund configuration for Progressive loan

dd316a4

adamsaghy force-pushed the FINERACT-2107/interest_refund_config branch from 457e76f to dd316a4 Compare July 23, 2024 16:33

alberto-art3ch approved these changes Jul 23, 2024

View reviewed changes

alberto-art3ch merged commit 7800d67 into master Jul 23, 2024
2 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

FINERACT-2107: Interest refund configuration for Progressive loan #2152

FINERACT-2107: Interest refund configuration for Progressive loan #2152

adamsaghy commented Jul 23, 2024

janez89 Jul 23, 2024

somasorosdpc Jul 23, 2024

alberto-art3ch left a comment

alberto-art3ch Jul 23, 2024

adamsaghy Jul 23, 2024

alberto-art3ch Jul 23, 2024

adamsaghy Jul 23, 2024

alberto-art3ch Jul 23, 2024

adamsaghy Jul 23, 2024

alberto-art3ch Jul 23, 2024

adamsaghy Jul 23, 2024

alberto-art3ch Jul 23, 2024

adamsaghy Jul 23, 2024

alberto-art3ch Jul 23, 2024

adamsaghy Jul 23, 2024

alberto-art3ch Jul 23, 2024

adamsaghy Jul 23, 2024

alberto-art3ch Jul 23, 2024

adamsaghy Jul 23, 2024

alberto-art3ch Jul 23, 2024

adamsaghy Jul 23, 2024

alberto-art3ch left a comment

FINERACT-2107: Interest refund configuration for Progressive loan #2152

FINERACT-2107: Interest refund configuration for Progressive loan #2152

Conversation

adamsaghy commented Jul 23, 2024

Description

Related issues and discussion

Screenshots, if any

Checklist

Choose a reason for hiding this comment

Choose a reason for hiding this comment

alberto-art3ch left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

alberto-art3ch left a comment

Choose a reason for hiding this comment