Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link to governance rules in pull request template #29

Merged
merged 4 commits into from
Oct 11, 2023

Conversation

ClemensLinnhoff
Copy link
Contributor

@ClemensLinnhoff ClemensLinnhoff commented Sep 20, 2023

Add a description
Fix link to governance rules in pull request template

Take this checklist as orientation for yourself, if this PR is ready for Maintainer Review

  • My suggestion follows the governance rules.
  • All commits of this PR are signed.
  • My changes generate no errors when passing CI tests.
  • I updated all documentation (readmes incl. figures) according to my changes.
  • I have successfully implemented and tested my fix/feature locally.
  • Appropriate reviewer(s) are assigned.

Signed-off-by: ClemensLinnhoff <Clemens.Linnhoff@partner.bmw.de>
@ClemensLinnhoff ClemensLinnhoff added the bug Something isn't working label Sep 20, 2023
@jdsika
Copy link
Contributor

jdsika commented Oct 10, 2023

@ClemensLinnhoff I guess this is superceeded by the doc-move-pr?

@ClemensLinnhoff
Copy link
Contributor Author

@ClemensLinnhoff I guess this is superceeded by the doc-move-pr?

You are right. I just updated it.

@ClemensLinnhoff ClemensLinnhoff self-assigned this Oct 10, 2023
@jdsika jdsika closed this Oct 10, 2023
@ClemensLinnhoff
Copy link
Contributor Author

@jdsika why did you close this PR without merging? The broken link still needs to be fixed.

@jdsika
Copy link
Contributor

jdsika commented Oct 11, 2023

@jdsika why did you close this PR without merging? The broken link still needs to be fixed.

sorry, I thought you fixed it in the other PR as I read it as "yes, it is superseded" :) I will merge this asap

@jdsika jdsika merged commit c5af586 into main Oct 11, 2023
2 checks passed
@jdsika jdsika deleted the fix-broken-link-in-template branch October 11, 2023 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants