Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove documentation pages already contained in new doc repository #33

Merged
merged 2 commits into from
Oct 10, 2023

Conversation

ClemensLinnhoff
Copy link
Contributor

Add a description
Documentation pages are removed, that are now included in the new documentation repository. It builds the new documentation at https://openmsl.github.io/doc/

Take this checklist as orientation for yourself, if this PR is ready for Maintainer Review

  • My suggestion follows the governance rules.
  • All commits of this PR are signed.
  • My changes generate no errors when passing CI tests.
  • I updated all documentation (readmes incl. figures) according to my changes.
  • I have successfully implemented and tested my fix/feature locally.
  • Appropriate reviewer(s) are assigned.

Signed-off-by: ClemensLinnhoff <Clemens.Linnhoff@partner.bmw.de>
@jdsika
Copy link
Contributor

jdsika commented Oct 10, 2023

traffic participant template got lost in the links

@jdsika
Copy link
Contributor

jdsika commented Oct 10, 2023

I guess CONTRIBUTING etc needs to stay in this .github repo? What about the things in this doc folder? Should we move this as well to the doc repository?

Signed-off-by: ClemensLinnhoff <Clemens.Linnhoff@partner.bmw.de>
@ClemensLinnhoff
Copy link
Contributor Author

traffic participant template got lost in the links

I re-added it

@ClemensLinnhoff
Copy link
Contributor Author

I guess CONTRIBUTING etc needs to stay in this .github repo? What about the things in this doc folder? Should we move this as well to the doc repository?

Yes, Contributing etc. needs to stay here, because GitHub automatically finds and links it.

In the doc folder only the integration test readme template remains. I would leave it here, since other templates, e.g. for pull requests and issues, are also in the .github repo. It is linked from the documentation and from the readme in the model template repo.

@jdsika jdsika added the documentation Improvements or additions to documentation label Oct 10, 2023
@jdsika jdsika merged commit 8f1dc79 into main Oct 10, 2023
2 checks passed
@ClemensLinnhoff ClemensLinnhoff deleted the move-doc-to-doc-repo branch October 11, 2023 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants