Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toml11: Don't install internally shipped library #1210

Closed
wants to merge 1 commit into from
Closed

Toml11: Don't install internally shipped library #1210

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,19 @@ target_link_libraries(openPMD::thirdparty::nlohmann_json

# external library: toml11
if(openPMD_USE_INTERNAL_TOML11)
add_subdirectory("${openPMD_SOURCE_DIR}/share/openPMD/thirdParty/toml11")
# EXCLUDE_FROM_ALL ensures that toml11 is not part of
# make install.
# The library is header-only and linking it against
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be more precise: the library is private and not used in our public API interfaces (aka no types from it are used in our header files) :)

# PIConGPU targets is sufficient.
# It needs not be part of any build or install targets
# explicitly.
add_subdirectory(
"${openPMD_SOURCE_DIR}/share/openPMD/thirdParty/toml11"
EXCLUDE_FROM_ALL)
mark_as_advanced(
toml11_BUILD_TEST
toml11_TEST_WITH_ASAN
toml11_TEST_WITH_UBSAN)
message(STATUS "toml11: Using INTERNAL version '3.7.0'")
else()
find_package(toml11 3.7.0 CONFIG REQUIRED)
Expand Down