Fix: Artifact Placement in Windows Wheels #1400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our `setup.py` wheel logic currently picks up our libs and Python module straight from the build directory. The latest changes then misplaced the artifacts in the final wheel. Add a tweak to CMake that allows to overwrite this for the two targets (lib and python module). This will be modernized at some point using `scikit-build`.
ax3l
changed the title
setup.py)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our
setup.pywheel logic currently picks up our libs and Python module straight from the build directory. The latest changes then misplaced the artifacts in the final wheel.Add a tweak to CMake that allows to overwrite this for the two targets (lib and python module).
This will be modernized at some point using
scikit-build.Regression to #1384