CMake 3.24+: ZLIB_USE_STATIC_LIBS #1410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recent CMake versions add a control variable to ensure only a static zlib is picked up.
ax3l
added
install
backend: HDF5
backend: ADIOS2
dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent CMake versions add a control variable to ensure only a static zlib is picked up.
This should not be needed in our own build (
setup.py, similar toHDF5_USE_STATIC_LIBRARIES) because we do not depend on ZLIB directly, but transitively through dependencies such as HDF5 and ADIOS1/2->c-blosc