Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iteration::open() #862

Merged
merged 5 commits into from
Jan 3, 2021
Merged

Iteration::open() #862

merged 5 commits into from
Jan 3, 2021

Conversation

ax3l
Copy link
Member

@ax3l ax3l commented Dec 23, 2020

Fix #856

@ax3l ax3l added bug MPI api: new additions to the API labels Dec 23, 2020
src/Iteration.cpp Outdated Show resolved Hide resolved
@ax3l ax3l mentioned this pull request Dec 23, 2020
src/Iteration.cpp Outdated Show resolved Hide resolved
Co-authored-by: Franz Pöschel <franz.poeschel@gmail.com>
Skip ADIOS1 coverage for now, it's blocking the release.
@ax3l ax3l changed the title [WIP] Iteration::open() Iteration::open() Jan 3, 2021
@ax3l
Copy link
Member Author

ax3l commented Jan 3, 2021

I'll merge this for now, since ADIOS2 & HDF5 work, which is sufficient to unblock the 0.13.0 release #861 .

I will open a follow-up PR for ADIOS1 where we can fix that backend as well, which can go into 0.13.1/0.14.0.

@ax3l ax3l dismissed franzpoeschel’s stale review January 3, 2021 22:06

Changes added from review.

@ax3l ax3l merged commit 66af2b4 into openPMD:dev Jan 3, 2021
@ax3l ax3l deleted the topic-iterationOpen branch January 3, 2021 22:36
franzpoeschel added a commit to franzpoeschel/openPMD-api that referenced this pull request Jan 29, 2021
* Test: non-collective, parallel read
* Iteration::open()
* Enforce strict opening of files in ADIOS2
* use general flush implementation
* file_based_write_read: Skip ADIOS1
* Skip ADIOS1 coverage for now, it's blocking the release.

Co-authored-by: Franz Pöschel <franz.poeschel@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Read from one (out of many) ranks.
2 participants