possibility to configure kill_pgid also via environment variable #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please rebase this? We have changed the license from GPL-3.0-or-later to GPL-2.0-or-later and we need you to rebase it in order to confirm that you agree with the new license terms. |
Signed-off-by: Michael Rodler <m@mrodler.eu>
|
@cyphar done. |
cyphar
requested changes
Sep 17, 2024
| @@ -482,6 +482,11 @@ int main(int argc, char **argv) | |||
| if (argc < 1 && !run_as_pause) | |||
| bail_usage("missing program name"); | |||
|
|
|||
| char *kill_pgid_env = secure_getenv("CATATONIT_KILLPG"); | |||
There was a problem hiding this comment.
secure_getenv doesn't make sense in this context -- secure_getenv is only relevant for setuid binaries (and even then, it only really makes sense for general purpose libraries that might be used by a setuid binary).
Comment on lines
+486
to
+488
| if (kill_pgid_env != NULL) { | ||
| kill_pgid = true; | ||
| } |
There was a problem hiding this comment.
Please use the Linux kernel style:
Suggested change
| if (kill_pgid_env != NULL) { | |
| kill_pgid = true; | |
| } | |
| if (kill_pgid_env) | |
| kill_pgid = true; |
or even just do:
Suggested change
| if (kill_pgid_env != NULL) { | |
| kill_pgid = true; | |
| } | |
| kill_pgid |= getenv("CATATONIT_KILLPG") != NULL; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes it is inconvenient to pass a command line flag to catatonit, e.g., the
-gflag. So this PR adds environment variable to configure catatonit to forward signals to the whole process group.