Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multipath-tools 0.10.1 and 0.10.2 #17

Closed
wants to merge 32 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
43ef161
GitHub workflows: use {upload,download}-artifact@v4
mwilck Sep 13, 2024
2e552e3
GitHub workflows: update dawidd6/action-download-artifact
mwilck Sep 13, 2024
978f2cb
Github workflows: native.yml: use mosteo-actions/docker-run
mwilck Sep 13, 2024
1d44836
GitHub workflows: native.yml: use extra job for clang
mwilck Sep 13, 2024
01ced67
GitHub workflows: native.yaml: make test and archive separately
mwilck Sep 13, 2024
6c6330d
GitHub workflows: enable unit tests for stable branches
mwilck Nov 14, 2024
c90c971
GitHub Workflows: add abi check for stable branches
mwilck Nov 14, 2024
e886480
libmultipath: dm_get_maps(): don't bail out for single-map failures
mwilck Nov 12, 2024
1a9ad29
11-dm-mpath.rules.in: import DM_COLDPLUG_SUSPENDED only once
mwilck Oct 31, 2024
ce38572
11-dm-mpath.rules.in: handle inactive suspended devices correctly
mwilck Oct 31, 2024
1183dc5
11-dm-mpath.rules.in: clarify DM_ACTIVATION logic
mwilck Oct 31, 2024
be50c2f
11-dm-mpath-rules.in: skip one .DM_NOSCAN check
mwilck Nov 3, 2024
1548380
11-dm-mpath.rules.in: set .DM_NOSCAN if MPATH_UNCHANGED is set
mwilck Nov 3, 2024
d40acc4
libmultipath: don't set dev_loss_tmo to 0 for NO_PATH_RETRY_FAIL
mwilck Nov 7, 2024
5ca938a
multipathd: fix deferred_failback_tick for reload removes
bmarzins Oct 15, 2024
444530d
multipathd: fix an unsigned int ovwerflow
mwilck Nov 13, 2024
62f5fac
libmpathutil: avoid -Wcast-function-type-mismatch error with clang 19
mwilck Nov 6, 2024
c994e84
Update NEWS.md for 0.10.1
mwilck Nov 14, 2024
84a4dcc
libmultipath: don't print error message if WATCHDOG_USEC is 0
mwilck Nov 14, 2024
b2642d2
libmultipath: reduce log level of "map X has multiple targets"
mwilck Nov 25, 2024
3dc6a89
libmultipath/foreign: fix memory leak in nvme foreign handler
bmarzins Jan 9, 2025
b3d82d8
libmultipath: add condition for enqueueing path to io error check
chenrenhui-hw Jan 10, 2025
f793a9e
Additional NEWS.md updates for 0.10.1
mwilck Jan 17, 2025
e860ef5
libmultipath: fix handling of pp->pgindex
mwilck Nov 25, 2024
8c62ec3
libmultipath: make pgcmp detect if map is missing a path group
mwilck Nov 25, 2024
1eb0719
libmultipath: trigger uevents upon map creation in domap()
mwilck Nov 26, 2024
6de0c88
multipathd: trigger uevents upon map removal in coalesce_maps()
mwilck Nov 27, 2024
70d8a40
libmultipath: Don't skip set_path_max_sectors_kb()
bmarzins Dec 5, 2024
9666a0f
libmultipath: stop static analyzer complaint in init_foreign
bmarzins Jan 23, 2025
0514280
libmultipath: be lenient in allowing the alua-based pgpolicies
bmarzins Jan 23, 2025
02797bb
Update NEWS.md for 0.10.2
mwilck Jan 24, 2025
ab323f5
GitHub Workflows: fix abi-stable.yaml for pull request
mwilck Jan 24, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/actions/spelling/expect.txt
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ ata
autoconfig
autodetected
autoresize
backported
barbie
BINDIR
blkid
Expand Down Expand Up @@ -122,6 +123,7 @@ Lun
lvm
lvmteam
Marzinski
misdetection
mpath
mpathb
mpathpersist
Expand Down Expand Up @@ -184,7 +186,6 @@ sas
sbp
scsi
sda
sdc
setmarginal
setprkey
setprstatus
Expand All @@ -205,11 +206,11 @@ suse
svg
switchgroup
sys
SYSDIR
sysfs
sysinit
tcp
terabytes
SYSDIR
TESTDEPS
testname
tgill
Expand All @@ -231,6 +232,7 @@ unsetprkey
unsetprstatus
unspec
usb
USEC
userdata
userspace
usr
Expand Down
97 changes: 97 additions & 0 deletions .github/workflows/abi-stable.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,97 @@
name: check-abi for stable branch
on:
push:
branches:
- 'stable-*'
paths:
- '.github/workflows/abi-stable.yaml'
- '**.h'
- '**.c'
- '**.version'
pull_request:
branches:
- 'stable-*'
workflow_dispatch:

jobs:
reference-abi:
runs-on: ubuntu-22.04
steps:
- name: get parent tag
run: >
echo ${{ github.ref }} |
sed -E 's,refs/heads/stable-([0-9]\.[0-9]*)\.y,PARENT_TAG=\1.0,' >> $GITHUB_ENV
if: ${{ github.event_name == 'push' }}
- name: get parent tag
run: echo PARENT_TAG=${{ github.base_ref }} >> $GITHUB_ENV
if: ${{ github.event_name == 'pull_request' }}
- name: assert parent tag
run: /bin/false
if: ${{ env.PARENT_TAG == '' }}
- name: update
run: sudo apt-get update
- name: dependencies
run: >
sudo apt-get install --yes gcc
gcc make pkg-config abigail-tools
libdevmapper-dev libreadline-dev libaio-dev libsystemd-dev
libudev-dev libjson-c-dev liburcu-dev libcmocka-dev libedit-dev
- name: checkout ${{ env.PARENT_TAG }}
uses: actions/checkout@v4
with:
ref: ${{ env.PARENT_TAG }}
- name: build ABI for ${{ env.PARENT_TAG }}
run: make -j$(grep -c ^processor /proc/cpuinfo) -Orecurse abi
- name: save ABI
uses: actions/upload-artifact@v4
with:
name: multipath-abi-${{ env.PARENT_TAG }}
path: abi

check-abi:
runs-on: ubuntu-22.04
needs: reference-abi
steps:
- name: get parent tag
run: >
echo ${{ github.ref }} |
sed -E 's,refs/heads/stable-([0-9]\.[0-9]*)\.y,PARENT_TAG=\1.0,' >> $GITHUB_ENV
if: ${{ github.event_name == 'push' }}
- name: get parent tag
run: echo PARENT_TAG=${{ github.base_ref }} >> $GITHUB_ENV
if: ${{ github.event_name == 'pull_request' }}
- name: assert parent tag
run: /bin/false
if: ${{ env.PARENT_TAG == '' }}
- name: checkout ${{ github.base_ref }}
uses: actions/checkout@v4
with:
ref: ${{ github.base_ref }}
- name: download ABI for ${{ env.PARENT_TAG }}
id: download_abi
uses: actions/download-artifact@v4
with:
name: multipath-abi-${{ env.PARENT_TAG }}
path: reference-abi
- name: update
run: sudo apt-get update
if: steps.download_abi.outcome != 'success'
- name: dependencies
run: >
sudo apt-get install --yes gcc
gcc make pkg-config abigail-tools
libdevmapper-dev libreadline-dev libaio-dev libsystemd-dev
libudev-dev libjson-c-dev liburcu-dev libcmocka-dev libedit-dev
- name: check ABI of ${{ github.ref }} against ${{ env.PARENT_TAG }}
id: check_abi
run: make -j$(grep -c ^processor /proc/cpuinfo) -Orecurse abi-test
continue-on-error: true
- name: save differences
if: ${{ steps.check_abi.outcome != 'success' }}
uses: actions/upload-artifact@v4
with:
name: abi-test
path: abi-test
- name: fail
run: /bin/false
if: steps.check_abi.outcome != 'success'
8 changes: 5 additions & 3 deletions .github/workflows/abi.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
- name: get reference ABI
id: reference
continue-on-error: true
uses: dawidd6/action-download-artifact@v2
uses: dawidd6/action-download-artifact@v6
with:
workflow: abi.yaml
branch: ${{ env.ABI_BRANCH }}
Expand All @@ -45,21 +45,23 @@ jobs:
- name: create ABI
run: make -Orecurse -j$(grep -c ^processor /proc/cpuinfo) abi.tar.gz
- name: save ABI
uses: actions/upload-artifact@v1
uses: actions/upload-artifact@v4
with:
name: abi
path: abi
overwrite: true
- name: compare ABI against reference
id: compare
continue-on-error: true
if: ${{ steps.reference.outcome == 'success' }}
run: make abi-test
- name: save differences
if: ${{ steps.compare.outcome == 'failure' }}
uses: actions/upload-artifact@v1
uses: actions/upload-artifact@v4
with:
name: abi-test
path: abi-test
overwrite: true

- name: fail
# MUST use >- here, otherwise the condition always evaluates to true
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/build-and-unittest.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,12 @@ on:
- master
- queue
- tip
- 'stable-*'
pull_request:
branches:
- master
- queue
- 'stable-*'
jobs:
jammy:
runs-on: ubuntu-22.04
Expand Down
17 changes: 9 additions & 8 deletions .github/workflows/foreign.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ on:
- master
- queue
- tip
- 'stable-*'
paths:
- '.github/workflows/foreign.yaml'
- '**.h'
Expand All @@ -15,6 +16,7 @@ on:
branches:
- master
- queue
- 'stable-*'
paths:
- '.github/workflows/foreign.yaml'
- '**.h'
Expand All @@ -36,14 +38,13 @@ jobs:
- name: checkout
uses: actions/checkout@v1
- name: build
run: make -j8 -Orecurse test-progs
- name: create binary archive
run: make test-progs.tar
run: make -j -Orecurse test-progs.tar
- name: upload binary archive
uses: actions/upload-artifact@v1
uses: actions/upload-artifact@v4
with:
name: cross-${{ matrix.os }}-${{ matrix.arch }}
path: test-progs.tar
overwrite: true

test:
runs-on: ubuntu-22.04
Expand All @@ -61,11 +62,11 @@ jobs:
run: echo CONTAINER_ARCH="arm/v7" >> $GITHUB_ENV
if: ${{ matrix.arch == 'armhf' }}
- name: download binary archive
uses: actions/download-artifact@v1
uses: actions/download-artifact@v4
with:
name: cross-${{ matrix.os }}-${{ matrix.arch }}
- name: unpack binary archive
run: tar xfv cross-${{ matrix.os }}-${{ matrix.arch }}/test-progs.tar
run: tar xfv test-progs.tar
- name: enable foreign arch
uses: dbhi/qus/action@main
- name: run tests
Expand Down Expand Up @@ -100,11 +101,11 @@ jobs:
run: echo CONTAINER_ARCH="arm/v7" >> $GITHUB_ENV
if: ${{ matrix.arch == 'armhf' }}
- name: download binary archive
uses: actions/download-artifact@v1
uses: actions/download-artifact@v4
with:
name: cross-${{ matrix.os }}-${{ matrix.arch }}
- name: unpack binary archive
run: tar xfv cross-${{ matrix.os }}-${{ matrix.arch }}/test-progs.tar
run: tar xfv test-progs.tar
- name: enable foreign arch
uses: dbhi/qus/action@main
- name: run tests
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/multiarch-stable.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ on:
- master
- queue
- tip
- 'stable-*'
paths:
- '.github/workflows/multiarch-stable.yaml'
- '**.h'
Expand All @@ -15,6 +16,7 @@ on:
branches:
- master
- queue
- 'stable-*'
paths:
- '.github/workflows/multiarch-stable.yaml'
- '**.h'
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/multiarch.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ on:
- master
- queue
- tip
- 'stable-*'
paths:
- '.github/workflows/multiarch.yaml'
- '**.h'
Expand All @@ -15,6 +16,7 @@ on:
branches:
- master
- queue
- 'stable-*'
paths:
- '.github/workflows/multiarch.yaml'
- '**.h'
Expand Down
Loading
Loading