Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add post-mortem september 2023 #429

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

saraycp
Copy link
Contributor

@saraycp saraycp commented Sep 19, 2023

No description provided.

@netlify
Copy link

netlify bot commented Sep 19, 2023

Deploy Preview for openbuildservice ready!

Name Link
🔨 Latest commit ec1d0aa
🔍 Latest deploy log https://app.netlify.com/sites/openbuildservice/deploys/6525334c06de62000812ddc3
😎 Deploy Preview https://deploy-preview-429--openbuildservice.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@saraycp saraycp force-pushed the post_mortem_20230919 branch 5 times, most recently from cba61a1 to 87562ef Compare September 19, 2023 15:49
_posts/deployments/2023-09-19-post-mortem.md Outdated Show resolved Hide resolved
_posts/deployments/2023-09-19-post-mortem.md Outdated Show resolved Hide resolved
_posts/deployments/2023-09-19-post-mortem.md Outdated Show resolved Hide resolved
_posts/deployments/2023-09-19-post-mortem.md Outdated Show resolved Hide resolved
_posts/deployments/2023-09-19-post-mortem.md Outdated Show resolved Hide resolved
_posts/deployments/2023-09-19-post-mortem.md Outdated Show resolved Hide resolved
_posts/deployments/2023-09-19-post-mortem.md Outdated Show resolved Hide resolved
_posts/deployments/2023-09-19-post-mortem.md Outdated Show resolved Hide resolved
@saraycp saraycp force-pushed the post_mortem_20230919 branch 2 times, most recently from 1ddc83d to 26c9c3a Compare September 20, 2023 12:23
@saraycp
Copy link
Contributor Author

saraycp commented Sep 20, 2023

@hennevogel I already pushed all the changes you suggested. Despite the fact that there were errors about conde_of_conduct as well.

The errors with conde_of_conduct happened in less than one minute, not so relevant...
First Notice: Sep 19 08:27:58 Last Notice: Sep 19 08:28:31

@saraycp saraycp closed this Sep 20, 2023
@saraycp saraycp reopened this Sep 20, 2023
@saraycp saraycp force-pushed the post_mortem_20230919 branch 2 times, most recently from f8f9aef to c283e7c Compare September 21, 2023 08:09
@saraycp saraycp marked this pull request as draft September 22, 2023 12:48
@ncounter
Copy link
Contributor

@saraycp what is the state of this PR?

@saraycp saraycp force-pushed the post_mortem_20230919 branch 2 times, most recently from 4e7b963 to 25bcefc Compare October 4, 2023 08:39
@saraycp
Copy link
Contributor Author

saraycp commented Oct 4, 2023

@saraycp what is the state of this PR?

The blog post missed the Action Items section. I needed time to do some research and testing in order to provide possible solutions. As it is not straightforward, I've decided to add a generic text and go on working on it after this post-mortem is published:

"Plan a strategy to deploy migrations. It might include separating migration deployment from the code changes deployment or splitting the migration into different steps"

@saraycp saraycp force-pushed the post_mortem_20230919 branch 2 times, most recently from 4a943f0 to b0d3991 Compare October 5, 2023 07:54
@saraycp saraycp marked this pull request as ready for review October 5, 2023 07:54
@bmwiedemann
Copy link
Member

"Plan a strategy to deploy migrations. It might include separating migration deployment from the code changes deployment or splitting the migration into different steps"

That is a sensible approach. First we do the required changes to the database, ensure everything keeps working as before and in a 2nd deployment we add code to use the new DB parts. Would that split happen on the git level, where the PR to use the new parts would wait longer for merge?

@saraycp
Copy link
Contributor Author

saraycp commented Oct 5, 2023

"Plan a strategy to deploy migrations. It might include separating migration deployment from the code changes deployment or splitting the migration into different steps"

That is a sensible approach. First we do the required changes to the database, ensure everything keeps working as before and in a 2nd deployment we add code to use the new DB parts. Would that split happen on the git level, where the PR to use the new parts would wait longer for merge?

The order migration deployment + changes deployment works for the addition of columns/tables.
For removals, the order should be changes deployment + migration deployment, as we need the code to stop using those columns/tables before we remove them.

So far, we have relied on labels like "Reference Server" or "Do Not Merge" to avoid merging and deploying PRs that require special attention. We can use them for the cases we mentioned before until we find a better way to do that.

@saraycp saraycp merged commit cab52ca into openSUSE:master Oct 10, 2023
3 checks passed
@saraycp saraycp deleted the post_mortem_20230919 branch October 10, 2023 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants