Only clean up pastes which exist #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 10653381576Details
💛 - Coveralls |
hellcp
reviewed
Sep 1, 2024
If pastes would be deleted administratively before the scheduled expiry cleanup took place, the cleanup job would, once the schedule hit, return "Error performing PastesCleanupJob" along with a long traceback about the failure. Handle the situation gracefully and avoid the failure by validating whether the paste exists before attempting to delete it. To achieve this, the paste ID instead of the paste object must be passed to the job, as otherwise the object in the queue might no longer be pointing to any valid paste, not allowing for validation of it inside the function. Signed-off-by: Georg Pfuetzenreuter <mail@georg-pfuetzenreuter.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If pastes would be deleted administratively before the scheduled expiry cleanup took place, the cleanup job would, once the schedule hit, return "Error performing PastesCleanupJob" along with a long traceback about the failure.
Handle the situation gracefully and avoid the failure by validating whether the paste exists before attempting to delete it.
To achieve this, the paste ID instead of the paste object must be passed to the job, as otherwise the object in the queue might no longer be pointing to any valid paste, not allowing for validation of it inside the function.
https://progress.opensuse.org/issues/166121