rollback bootloader after setting default snapshot #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TobiPeterG
commented
Jun 22, 2024
aplanas
reviewed
Jun 24, 2024
TobiPeterG
force-pushed
the
rollback_bootloader
branch
from
5361fad
to
0bf666f
Compare
|
This makes needs_update way more verbose, personally, I like that. |
TobiPeterG
force-pushed
the
rollback_bootloader
branch
from
0bf666f
to
01d97a7
Compare
TobiPeterG
force-pushed
the
rollback_bootloader
branch
from
01d97a7
to
4dcb8dc
Compare
|
ping |
Rebase it, sure. But I will need more time to review 😞 |
This makes sure that the bootloader version always matches the version found on the system
TobiPeterG
force-pushed
the
rollback_bootloader
branch
from
4dcb8dc
to
3e5d985
Compare
|
Hey, I finally found the time to rebase, feel free to test and review :) |
aplanas
approved these changes
Oct 23, 2024
|
Moved here: #150 |
|
Oh thank you, I'm sorry that I didn't have a look at your review yet, I'm sick for quite a while now. :( I planned on working on sdbootutil, but I was laying in bed instead. I will be though when I'm back on full power :) |
|
Please, take care of yourself!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
basic attempt to fix #77