-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a plugin mechanism to tukit #122
Conversation
Signed-off-by: Alberto Planas <aplanas@suse.com>
Signed-off-by: Alberto Planas <aplanas@suse.com>
Ready for reviews! cc @Vogtinator |
e4d8011
to
0b5449e
Compare
@laenion @Vogtinator ping? : ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general I like the approach - see the nits, but the place to call the plugins will have to be changed in any case.
(I'm still not sure whether it's a good idea to have the BindDir as part of the API, but I'll not complain for now ;-))
88d51b3
to
2acd833
Compare
@laenion should be ready for another pass |
Thanks a lot for all your work, everything is looking good now! Just one last thing: The last two commits are messed up, "tukit: move getBindDir as protected" now contains all the changes that should have gone into "tukit: add plugin mechanism" |
Signed-off-by: Alberto Planas <aplanas@suse.com>
Ah indeed. I squashed both. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good now, thanks a lot for your work!
Thanks for your reviews @laenion. That helped a lot. |
No description provided.