Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .editorconfig #65

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add .editorconfig #65

wants to merge 1 commit into from

Conversation

lnussel
Copy link
Member

@lnussel lnussel commented May 6, 2021

No description provided.

@laenion
Copy link
Collaborator

laenion commented May 6, 2021

The file https://github.com/openSUSE/transactional-update/blob/master/sbin/transactional-update.in has a more complicated indentation style: It's 4 spaces, followed by 1 tabs (taking up 8 spaces), followed by 1 tab 4 spaces etc. From what I can see this is not supported by EditorConfig?

@lnussel
Copy link
Member Author

lnussel commented May 6, 2021

that is what the config sets. Ie sw=4 ts=8

@laenion
Copy link
Collaborator

laenion commented May 6, 2021

I see - the website seems to be a bit misleading (or leaving out information). https://editorconfig-specification.readthedocs.io/#supported-pairs suggests that this may work, while https://editorconfig.org/#file-format-details just claims that indent_size will be used when indent_style is set to tab - implying that tab-width wouldn't be used. I guess you tested this with some editor already?

Apart from that: I think another header

[*/Makefile.am]

is required for correct tab indentation in those files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants