phase powers and currents added #1059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Created openWB/openwb-ui-settings#331 for accompanying GUI addition. |
|
@LKuemmel |
|
As I can tell from the common counter code, phase powers and currents are converted automatically if either one is available. My counter only has phase powers. Hence I implemented it. If you wish, I can add currents as well. Please let me know.
|
|
Thanks for also adding phase currents. Now this module seems to be complete. |
LKuemmel
approved these changes
Aug 4, 2023
|
Hi, why not implement L1, L2, L3 also, doesn't that make sense? |
|
You are talking about voltages? These are not necessary. If you would like to see them on the status page, please feel free to open an new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
web gui integration of additional arguments for json extraction of phase powers pending