Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPP #1893

Merged
merged 8 commits into from
Oct 10, 2024
Merged

OCPP #1893

merged 8 commits into from
Oct 10, 2024

Conversation

LKuemmel
Copy link
Contributor

@LKuemmel LKuemmel commented Sep 18, 2024 •
edited
Loading

@LKuemmel LKuemmel added this to the 2.1.6 milestone Sep 18, 2024
@LKuemmel LKuemmel marked this pull request as ready for review October 2, 2024 09:11
@LKuemmel LKuemmel requested a review from benderl October 2, 2024 09:11
@LKuemmel
Copy link
Contributor Author

LKuemmel commented Oct 2, 2024

braucht Rebase nach Merge von #1912, damit der Test läuft

benderl
benderl requested changes Oct 8, 2024
View reviewed changes
packages/main.py Outdated Show resolved Hide resolved
packages/helpermodules/update_config.py Outdated Show resolved Hide resolved
packages/helpermodules/update_config.py Outdated Show resolved Hide resolved
packages/helpermodules/setdata.py Outdated Show resolved Hide resolved
packages/control/optional_data.py Outdated Show resolved Hide resolved
packages/control/optional.py Outdated Show resolved Hide resolved
packages/control/optional.py Outdated Show resolved Hide resolved
packages/control/ocpp_test.py Outdated Show resolved Hide resolved
@LKuemmel LKuemmel merged commit 003ccf5 into openWB:master Oct 10, 2024
1 check passed
@LKuemmel LKuemmel deleted the ocpp branch October 10, 2024 06:58
@gerdemann
Copy link

gerdemann commented Oct 10, 2024 •
edited
Loading

I have tested these changes with our OCPP backend and it looks like it keeps establishing a new websocket connection, sending the request and then closing it again. Can't the connection be permanent?

#1932

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benderl benderl benderl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.1.6
Development

Successfully merging this pull request may close these issues.
3 participants
@LKuemmel @gerdemann @benderl