Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Increase CI robustness by using Heroku CLI #74

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

nickevansuk
Copy link
Contributor

@nickevansuk nickevansuk commented Aug 7, 2024

Deployment was failing, and the dependencies used for it are third-party and of questionable efficacy.

This PR updates CI to use Heroku's own CLI, which is bundled with the Github Actions Runner, and Git deployment. This is less likely to be fragile, as the CLI commands in use have remained stable for many years.

This change also restores deployment traceability to within Heroku, as deployments are now linked to Git commits.

@openactive-bot openactive-bot temporarily deployed to openactive-validator-pr-74 August 7, 2024 22:59 Inactive
@nickevansuk nickevansuk merged commit 6ac7cf6 into master Aug 7, 2024
8 checks passed
@nickevansuk nickevansuk deleted the ci/fix-heroku-deploy branch August 7, 2024 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants