Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Check for errors with TypeScript #446

Merged
merged 2 commits into from
Mar 11, 2024
Merged

Conversation

lukehesluke
Copy link
Contributor

@lukehesluke lukehesluke commented Mar 5, 2024

closes #447

@lukehesluke lukehesluke marked this pull request as ready for review March 5, 2024 17:55
README.md Outdated
@@ -229,7 +229,7 @@ To run tests locally, run:
$ npm test
```

The test run will also include a run of [eslint](https://eslint.org/). To run the tests without these, use:
The test run will also include a run of [eslint](https://eslint.org/) and [TypeScript](https://www.typescriptlang.org/). To run the tests without these, use:

```shell
$ npm run test-no-lint
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I'm being picky, this could be changed to test-no-lint-or-tsc or test-no-lint-tsc or only-test

@lukehesluke lukehesluke merged commit d6a8dba into master Mar 11, 2024
4 checks passed
@lukehesluke lukehesluke deleted the feature/typescript branch March 11, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeScript checking
2 participants