getDatasetSiteTemplate callback error #8
Conversation
Fix for: [ERROR] TypeError [ERR_INVALID_CALLBACK]: Callback must be a function. Received { encoding: 'utf8' }. Use fs.promises.readFile() which doesn't need a callback argument
|
DO NOT MERGE: Note that by default any PR on this repo may release a new version and cause a breaking change, so we need to work around this during release. |
|
@nickevansuk the Here's what happens if I run the function presently (using the same node version as in package.json, v14.16.0): // file: test.js
const { getDatasetSiteTemplate } = require('./lib');
main();
async function main() {
const x = await getDatasetSiteTemplate(true);
console.log(x);
}# terminal
$ node test.js
(node:17983) UnhandledPromiseRejectionWarning: TypeError [ERR_INVALID_CALLBACK]: Callback must be a function. Received { encoding: 'utf8' }
at maybeCallback (fs.js:160:9)
at Object.readFile (fs.js:311:14)
at getDatasetSiteTemplate (/Users/lukewinship/Dev/openactive/dataset-site-template/lib/index.js:19:19)
at main (/Users/lukewinship/Dev/openactive/dataset-site-template/test.js:6:19)
at Object.<anonymous> (/Users/lukewinship/Dev/openactive/dataset-site-template/test.js:3:1)
at Module._compile (internal/modules/cjs/loader.js:1063:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:1092:10)
at Module.load (internal/modules/cjs/loader.js:928:32)
at Function.Module._load (internal/modules/cjs/loader.js:769:14)
at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:72:12)
(Use `node --trace-warnings ...` to show where the warning was created)
(node:17983) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 2)
(node:17983) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.Then, if I run it with the fix from this patch applied, I get: # terminal
$ node test.js
<!DOCTYPE HTML>
<!--
OpenActive Dataset Site Template version 7, from https://unpkg.com/@openactive/dataset-site-template@7.0.0/dist/datasetsite.mustache
-->
# ... etc |
|
Sorry I wasn't clear in my previous comment @lukehesluke, agreed this fixes the issue, however the problem is that merging this will currently trigger CI which will cause a major version bump (which as you say is unnecessary, and is also disruptive to current implementations) The issue is this line: dataset-site-template/.github/workflows/deploy.yml Lines 27 to 28 in eacd582 Which must be resolved before this can be merged. Hopefully something that we can sort early in the next round of KT. |
|
For context, this is the (presently draft) issue that fixes the versioning issue: https://github.com/orgs/openactive/projects/17/views/1?pane=issue&itemId=35347051 |
Fix for: [ERROR] TypeError [ERR_INVALID_CALLBACK]: Callback must be a function. Received { encoding: 'utf8' }. Use fs.promises.readFile() which doesn't need a callback argument