Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix indent level in video recorder #2151

Closed
wants to merge 1 commit into from

Conversation

mattmolinare
Copy link

@mattmolinare mattmolinare commented Jan 8, 2021

Since it is declared after an exception is raised, the following statement on line 303 is never executed:

self.proc.stdin.write(frame.tobytes())

The solution is to once unindent the statement. Refer to #1925 (comment)

@vakker
Copy link
Contributor

vakker commented Mar 16, 2021

Is there any progress on this PR? It's a rather trivial fix, it should be merged asap.

@vakker
Copy link
Contributor

vakker commented Mar 17, 2021

@mattmolinare this was fixed in #2139 so I assume this PR is not relevant any more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants