Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix github language stats dominated by jupyter notebook #1076

Merged
merged 2 commits into from
Mar 14, 2023

Conversation

akashmjn
Copy link
Contributor

@akashmjn akashmjn commented Mar 11, 2023

Tiny PR identical to this :) karpathy/nanoGPT#115

Adds a .gitattributes file telling github to treat jupyter notebooks as "generated code" so that repo is no longer counted as 98% jupyter

Copy link

@glangford glangford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternately use linguist-vendored to preserve diffs

@glangford
Copy link

According to the github doc on overrides, the linguist-generated attribute causes files to be "excluded from stats, hidden in diffs". Whereas the linguist-vendored attribute causes only exclusion from stats. I think the diffs for notebooks would be useful, so should this be changed use linguist-vendored instead?

Reference
https://github.com/github/linguist/blob/master/docs/overrides.md

@jongwook
Copy link
Collaborator

I think no diffs might actually be better, because edits usually contain base64-encoded images and becomes quite unwieldy on native GitHub diffs, without third-party tools.

@jongwook jongwook merged commit ba88b8e into openai:main Mar 14, 2023
zackees pushed a commit to zackees/whisper that referenced this pull request May 5, 2023
…ai#1076)

Co-authored-by: Akash Mahajan <akash.mahajan@microsoft.com>
Co-authored-by: Jong Wook Kim <jongwook@openai.com>
ilanit1997 pushed a commit to ilanit1997/whisper that referenced this pull request May 16, 2023
…ai#1076)

Co-authored-by: Akash Mahajan <akash.mahajan@microsoft.com>
Co-authored-by: Jong Wook Kim <jongwook@openai.com>
abyesilyurt pushed a commit to abyesilyurt/whisper that referenced this pull request Nov 13, 2023
…ai#1076)

Co-authored-by: Akash Mahajan <akash.mahajan@microsoft.com>
Co-authored-by: Jong Wook Kim <jongwook@openai.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants