Fix bug where mm is mistakenly replaced with hmm in e.g. 20mm #659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. Those replacers are from the post-processing scripts for the CHiME dataset: but I agree it'd be not very relevant to keep it at this point. |
zackees
pushed a commit
to zackees/whisper
that referenced
this pull request
May 5, 2023
…#659) Co-authored-by: Jong Wook Kim <jongwook@nyu.edu>
ilanit1997
pushed a commit
to ilanit1997/whisper
that referenced
this pull request
May 16, 2023
…#659) Co-authored-by: Jong Wook Kim <jongwook@nyu.edu>
abyesilyurt
pushed a commit
to abyesilyurt/whisper
that referenced
this pull request
Nov 13, 2023
…#659) Co-authored-by: Jong Wook Kim <jongwook@nyu.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The English normaliser mistakenly replaces 20mm to 20hmm. In this case "mm" is the unit postfix millimetre.
This was caused by treating 10 as number and thus splitting "10" and "mm". The "mm" token was then further replaced with "hmm" according to the English.json mapping.
Removing "mm" from the mapping shouldn't be a problem, since there is already a condition before that that would remove "mm" words entirely from the input.
"mhm" and "mmm" could probably be removed for the same reason.