Feat/use inp #7
Merged
Feat/use inp #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
herablog
reviewed
Jun 3, 2022
| @@ -4,8 +4,10 @@ import { | |||
| getFID, | |||
| getLCP, | |||
| getTTFB, | |||
| onINP, | |||
There was a problem hiding this comment.
INP以外も on* にしておいた方が良かったりするかな!?
https://github.com/GoogleChrome/web-vitals/tree/next
There was a problem hiding this comment.
これまだnextなので悩み中ですw
stableに入ってからでも良いかなと思ったりしてます
There was a problem hiding this comment.
今読み込んでる3.0.0-beta.2はnextと同等 (versionsタブを参照)なのでbetaとして出すなら揃えちゃっていいかもなぁ。
まあどっちでも読んでも中身は一緒なんですがｗ
https://github.com/GoogleChrome/web-vitals/blob/next/src/deprecated.ts
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
INP(Interaction to Next Paint)の計測スクリプトを追加しました。
INPはFIDを拡張したもので、click, keypressなどのeventが発生してから次のpaint処理が走るまでの時間を計測します。
ユーザーのインタラクションから次のframeが表示されるまでに以下のように時間が計測されます。
指標は以下のようになっています。
web-vitalsライブラリではINPに閾値を設定できて、defaultでは40ms以下はデータを取得しないようになっています。
詳細は https://web.dev/inp/ を確認してください。
INPはまだexperimentalな仕様なので今後変わる可能性があります。
そのためstableリリースではなく、
npm version prerelease --preid=betaとしてリリースします。