-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Thinking of IE 🤔 #104
Merged
Merged
Thinking of IE 🤔 #104
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
89c9aa8
chore(spindle-ui): load CSS custom properties polyfill in Storybook
herablog 22f007e
docs(spindle-ui): browser support
herablog 6fc6a13
fix(spindle-ui): apply button align-items: center in IE11
herablog 3a27ab0
docs(spindle-ui): button state patterns
herablog File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -67,6 +67,18 @@ | |
padding-right: 10px; | ||
} | ||
|
||
/* | ||
* Setting height to a value less then min-height fixes the align-items: center issue in IE11 | ||
* @see https://github.com/philipwalton/flexbugs/issues/231#issue-245848315 | ||
*/ | ||
@media all and (-ms-high-contrast: none), (-ms-high-contrast: active) { | ||
.spui-Button--large, | ||
.spui-Button--medium, | ||
.spui-Button--small { | ||
height: 1px; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 高さ自体はなんでもよさげさん? |
||
} | ||
} | ||
|
||
/* | ||
* Button variants | ||
*/ | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
いくつか選択肢はあるけど、Storybookでは他のブラウザに影響を与えないこれで十分そう?なのでややお行儀の悪い方を入れてみました。
ref: #103 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@media
で IEでhover効いていないかもです。。。https://caniuse.com/mdn-css_at-rules_media_hover
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
こりはわかりにくくて恐縮なのだけど、想定内の動作になるのだ・・!
#13
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ドキュメントに記載しておきました〜 3a27ab0