Feat/add spindle hooks pkg #359

keiya01 · 2022-03-11T03:05:17Z

@openameba/spindle-hooks のpackageを追加しました。
spindle-uiからコピーしてきたファイルの中から不要なものを削除しました。

packages/spindle-hooks/docs/design-doc.md

packages/spindle-hooks/package.json

keiya01 · 2022-03-11T03:08:09Z

packages/spindle-hooks/package.json

+    "react": "^16.8.0 || ^17.0.0"
+  },
+  "dependencies": {},
+  "devDependencies": {


spindle-uiからコピーしたものの中から不要なものを削除しました
storybook, reg-suit, firebase, style周りのdepsを消しています

useCarouselの動きを確認するときにstorybookとfirebaseはあった方が良さそうなので入れちゃいます
reg-suitは迷っていますが動きの確認が中心になるのでなくても良いかなと思っています

b1f24c9
storybook追加してみました
設定はほとんどspindle-uiと同じです

keiya01 · 2022-03-11T03:08:23Z

packages/spindle-hooks/src/LICENSE

@@ -0,0 +1,21 @@
+MIT License


licenseはspindle-uiのままです

keiya01 · 2022-03-11T03:08:50Z

packages/spindle-hooks/bundlesize.config.json

+  "files": [
+    {
+      "path": "./dist/**/*.js",
+      "maxSize": "1 kB"


仮で1kbにしています

keiya01 · 2022-03-11T03:09:30Z

packages/spindle-hooks/README.md

@@ -0,0 +1,57 @@
+# Spindle Hooks (In development)


別途改善します

keiya01 · 2022-03-11T08:43:17Z

#175 を参考にESM考慮した方が良さそう

herablog · 2022-03-14T06:53:12Z

packages/spindle-hooks/src/useSample.test.ts

@@ -0,0 +1,5 @@
+import { useSample } from './useSample';
+
+test('useSample', () => {


keiya01 · 2022-03-14T07:21:14Z

packages/spindle-hooks/package.json

+  "main": "./dist/index.mjs",
+  "exports": "./dist/index.mjs",


cjsはないので"module"と区別していません。
exportsは指定されたパス以外でimportできないように制限できるようです:eyes:
https://shisama.hatenablog.com/entry/2020/12/21/090000

確かにhooksの新しいパッケージだしesm onlyで配信しても良さそうっすね。

あとこの辺も参考にやっておいた方がいいのかな.
https://gist.github.com/sindresorhus/a39789f98801d908bbc7ff3ecc99d99c#how-can-i-make-my-typescript-project-output-esm

a3d982d
一応enginesだけ設定しました:pray:
"type": "module"はjestが動かないので設定していないです

github-actions · 2022-03-28T03:54:00Z

Visit the preview URL for this PR (updated for commit 4d0e04d):

https://ameba-spindle-hooks--pr359-feat-add-spindle-hoo-7ed0ffcm.web.app

_{(expires Sun, 15 May 2022 09:04:44 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

keiya01 · 2022-03-29T03:42:57Z

https://ameba-spindle-hooks--pr359-feat-add-spindle-hoo-7ed0ffcm.web.app/
ameba-spindle-hooksにpreview反映されました

herablog

keiya01 · 2022-03-31T06:14:15Z

commitまとめたのでprereleaseしてみます

reg-suit · 2022-03-31T07:53:38Z

✨✨ That's perfect, there is no visual difference! ✨✨

Check out the report here.

- @openameba/spindle-hooks@0.0.1-alpha.0

- @openameba/spindle-hooks@0.0.1-alpha.1

- @openameba/spindle-hooks@0.0.1-alpha.2

- @openameba/spindle-hooks@0.0.1-alpha.3

chore(release): publish

keiya01 · 2022-04-18T10:00:17Z

packages/spindle-hooks/package.json

+    "prebuild": "yarn clean",
+    "build": "run-s build:esm build:cjs",
+    "build:cjs": "tsc -p tsconfig.cjs.json",
+    "build:esm": "run-s build:esm:js build:esm:rename",
+    "build:esm:js": "tsc -p tsconfig.esm.json",
+    "build:esm:rename": "npx renamer --find js --replace mjs 'dist/**'",
+    "prepublishOnly": "yarn build && yarn cp"


@herablog
この辺りだけspindle-uiに合わせてbundle作るように修正したのでざっと確認お願いします:pray:

Q. そういえば配信方法変更したのは、どこがうまく動かなかったんだっけか..!

Storybookがうまく動かずで変更しました！
type: "module" (内部でimport { Hoge } from "./mod.js"みたいに読み込んでいるケース) の場合にESMが動かなかっただけなのでmjsだけ配信して、cjsは配信しなくても良いかもです

こりと同じ問題て感じかな..!?
storybookjs/storybook#9854 (comment)

それです！リンク貼り忘れてましたすみません、、:pray:

いえいえ〜そのうち対応進みそうな気もするけど、タイミングがむずかしいね:pien_2:

難しいですね、、
他にもjestとかもまだexperimentalだったりするのでもあと少しという感じですかね、、

ですよね〜いろんなアプリケーションから使われる性質を考えると、修正してもらった方針でいきましょうか！

keiya01 · 2022-04-18T10:00:51Z

[MEMO]
このPRマージ後にuseTimeDistance追加する

herablog

keiya01 requested a review from herablog March 11, 2022 03:05

keiya01 self-assigned this Mar 11, 2022

keiya01 commented Mar 11, 2022

View reviewed changes

keiya01 force-pushed the feat/add-spindle-hooks-pkg branch 2 times, most recently from 831a58f to 3dd5083 Compare March 14, 2022 06:21

herablog reviewed Mar 14, 2022

View reviewed changes

keiya01 force-pushed the feat/add-spindle-hooks-pkg branch from 3dd5083 to 9f40fe9 Compare March 14, 2022 07:19

keiya01 commented Mar 14, 2022

View reviewed changes

keiya01 force-pushed the feat/add-spindle-hooks-pkg branch from b1f24c9 to 51e6f87 Compare March 29, 2022 03:34

herablog approved these changes Mar 31, 2022

View reviewed changes

keiya01 force-pushed the feat/add-spindle-hooks-pkg branch from eb52726 to ed2ecfd Compare March 31, 2022 06:13

keiya01 force-pushed the feat/add-spindle-hooks-pkg branch 3 times, most recently from c186003 to 17c7221 Compare March 31, 2022 07:49

keiya01 force-pushed the feat/add-spindle-hooks-pkg branch 5 times, most recently from ea51831 to 28eb9df Compare April 5, 2022 02:35

keiya01 force-pushed the feat/add-spindle-hooks-pkg branch 6 times, most recently from 23c6b5a to a1c93fc Compare April 12, 2022 04:33

keiya01 force-pushed the feat/add-spindle-hooks-pkg branch from a1c93fc to bed6014 Compare April 12, 2022 06:27

keiya01 marked this pull request as draft April 12, 2022 07:11

keiya01 force-pushed the feat/add-spindle-hooks-pkg branch 9 times, most recently from 82c3112 to 4f28736 Compare April 15, 2022 08:30

keiya01 and others added 5 commits April 15, 2022 17:34

feat(spindle-hooks): add spindle-hooks pkg

1d203af

feat(spindle-hooks): add useCarousel hooks

80adf49

chore(release): publish

079fee4

- @openameba/spindle-hooks@0.0.1-alpha.0

chore(release): publish

f9bd7cc

- @openameba/spindle-hooks@0.0.1-alpha.1

chore(release): publish

8a2e694

- @openameba/spindle-hooks@0.0.1-alpha.2

keiya01 force-pushed the feat/add-spindle-hooks-pkg branch from 4f28736 to 8a2e694 Compare April 15, 2022 08:34

openameba and others added 4 commits April 15, 2022 17:39

chore(release): publish

7315826

- @openameba/spindle-hooks@0.0.1-alpha.2

chore(release): publish

8a9d87b

- @openameba/spindle-hooks@0.0.1-alpha.3

Merge branch 'feat/add-spindle-hooks-pkg' into release/prerelease

9ea3760

Merge pull request #395 from openameba/release/prerelease

4d0e04d

chore(release): publish

keiya01 marked this pull request as ready for review April 18, 2022 09:47

keiya01 commented Apr 18, 2022

View reviewed changes

herablog approved these changes Apr 25, 2022

View reviewed changes

keiya01 merged commit 0b05e5a into main Apr 26, 2022

keiya01 deleted the feat/add-spindle-hooks-pkg branch April 26, 2022 02:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat/add spindle hooks pkg #359

Feat/add spindle hooks pkg #359

keiya01 commented Mar 11, 2022

keiya01 Mar 11, 2022

keiya01 Mar 28, 2022

keiya01 Mar 28, 2022

keiya01 Mar 11, 2022

keiya01 Mar 11, 2022

keiya01 Mar 11, 2022

keiya01 commented Mar 11, 2022

herablog Mar 14, 2022

keiya01 Mar 14, 2022

herablog Mar 15, 2022

keiya01 Mar 16, 2022 •

edited

Loading

github-actions bot commented Mar 28, 2022 •

edited

Loading

keiya01 commented Mar 29, 2022

herablog left a comment

keiya01 commented Mar 31, 2022

reg-suit bot commented Mar 31, 2022 •

edited

Loading

keiya01 Apr 18, 2022 •

edited

Loading

herablog Apr 25, 2022

keiya01 Apr 25, 2022 •

edited

Loading

herablog Apr 25, 2022

keiya01 Apr 25, 2022

herablog Apr 25, 2022

keiya01 Apr 25, 2022

herablog Apr 25, 2022

keiya01 commented Apr 18, 2022

herablog left a comment

		@@ -0,0 +1,5 @@
		import { useSample } from './useSample';

		test('useSample', () => {

Feat/add spindle hooks pkg #359

Feat/add spindle hooks pkg #359

Conversation

keiya01 commented Mar 11, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

keiya01 commented Mar 11, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

keiya01 Mar 16, 2022 • edited Loading

Choose a reason for hiding this comment

github-actions bot commented Mar 28, 2022 • edited Loading

keiya01 commented Mar 29, 2022

herablog left a comment

Choose a reason for hiding this comment

keiya01 commented Mar 31, 2022

reg-suit bot commented Mar 31, 2022 • edited Loading

keiya01 Apr 18, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

keiya01 Apr 25, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

keiya01 commented Apr 18, 2022

herablog left a comment

Choose a reason for hiding this comment

keiya01 Mar 16, 2022 •

edited

Loading

github-actions bot commented Mar 28, 2022 •

edited

Loading

reg-suit bot commented Mar 31, 2022 •

edited

Loading

keiya01 Apr 18, 2022 •

edited

Loading

keiya01 Apr 25, 2022 •

edited

Loading