Form components #89
Merged
Form components #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
reg-suit detected visual differences. Check this report, and review them. ⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪ What do the circles mean?The number of circles represent the number of changed images.🔴 : Changed items, ⚪ : New items, ⚫ : Deleted items, and 🔵 Passed items How can I change the check status?If reviewers approve this PR, the reg context status will be green automatically. |
|
Visit the preview URL for this PR (updated for commit 98184c0): https://ameba-spindle--pr89-feature-form-compone-dwjafddy.web.app (expires Fri, 25 Dec 2020 04:37:32 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
herablog
force-pushed
the
feature/form-components
branch
10 times, most recently
from
f94efd3
to
4df0215
Compare
herablog
commented
Nov 16, 2020
herablog
commented
Nov 16, 2020
|
IEでの確認は #104 がマージされてからが良さそうです。 |
tatz012
reviewed
Nov 17, 2020
herablog
commented
Nov 18, 2020
herablog
commented
Nov 18, 2020
herablog
commented
Nov 18, 2020
herablog
commented
Nov 18, 2020
herablog
commented
Nov 18, 2020
herablog
commented
Nov 18, 2020
herablog
force-pushed
the
feature/form-components
branch
2 times, most recently
from
865f1ca
to
e5bede1
Compare
herablog
force-pushed
the
feature/form-components
branch
from
e5bede1
to
daacbb2
Compare
3 tasks
herablog
commented
Nov 24, 2020
herablog
force-pushed
the
feature/form-components
branch
from
66545bb
to
de5903f
Compare
|
現在のステータスを更新。「Done is better than perfect」の精神で出せるものから出していくか。
|
hiloki
approved these changes
Nov 25, 2020
|
ありがとうございます〜docのstatus更新と、コミットログの都合上コミットまとめてリリースしてみます。 |
herablog
force-pushed
the
feature/form-components
branch
from
08898de
to
98184c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
こちらもプレビュー作るためにドラフトPRします。
Storybook: https://ameba-spindle--pr89-feature-form-compone-dwjafddy.web.app/?path=/docs/form-checkbox--checkbox