Skip to content

Commit

Permalink
Fix errorhandling for image_sdk_level
Browse files Browse the repository at this point in the history
  • Loading branch information
tsterbak committed Jan 14, 2024
1 parent 6da6055 commit b0110dd
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions openandroidinstaller/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,6 @@ def retrieve_image_metadata(image_path: str) -> dict:
logger.info(f"Metadata retrieved from image {image_path.split('/')[-1]}.")
return metadata_dict
except zipfile.BadZipFile as e:
logger.error("Selected image is not a zip file.")
raise e
except (FileNotFoundError, KeyError):
logger.error(
Expand All @@ -110,12 +109,12 @@ def image_sdk_level(image_path: str) -> int:
Returns:
Android version as integer.
"""
metadata = retrieve_image_metadata(image_path)
try:
metadata = retrieve_image_metadata(image_path)
sdk_level = metadata["post-sdk-level"]
logger.info(f"Android version of {image_path}: {sdk_level}")
return int(sdk_level)
except (ValueError, TypeError, KeyError) as e:
except (ValueError, TypeError, KeyError, zipfile.BadZipFile) as e:
logger.error(f"Could not determine Android version of {image_path}. Error: {e}")
return -1

Expand Down Expand Up @@ -149,6 +148,7 @@ def image_works_with_device(
f"Image file {image_path.split('/')[-1]} is not supported by device code.",
)
except zipfile.BadZipFile:
logger.error("Selected image is not a zip file.")
return CheckResult(
CompatibilityStatus.INCOMPATIBLE,
f"Selected image {image_path.split('/')[-1]} is not a zip file.",
Expand Down

0 comments on commit b0110dd

Please sign in to comment.