Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugs & problems with the flashing progress bar #103

Closed
MagicLike opened this issue Mar 12, 2023 · 2 comments
Closed

Bugs & problems with the flashing progress bar #103

MagicLike opened this issue Mar 12, 2023 · 2 comments

Comments

@MagicLike
Copy link
Member

MagicLike commented Mar 12, 2023 •
edited
Loading

When I install a new OS on my OnePlus One the progress bar of TWRP is way faster than the one of OAI, When TWRP is finished, the advanced output throws the error adb: failed to read command: Success, but continues with the script without any issues... (It only gets to 47%)
@MagicLike MagicLike mentioned this issue Mar 24, 2023
Closed
@MagicLike MagicLike changed the title TWRP progress bar while flashing is faster than the one of OAI Bugs withe the flashing progress bar Mar 24, 2023
@MagicLike MagicLike changed the title Bugs withe the flashing progress bar Bugs & problems with the flashing progress bar Mar 24, 2023
@MagicLike
Copy link
Member Author

MagicLike commented Mar 24, 2023 •
edited
Loading

Also if addons are flashed, there is a second progress bar, which appears under the first one. (It has the same problems.)
Maybe a joint bar for both actions or a combination of "progress of current action" and "progress of all actions" would be better.

Fixed in #139 / 540df59

@clstaudt clstaudt mentioned this issue Mar 31, 2023
Open
@tsterbak tsterbak mentioned this issue Apr 11, 2023
Merged
1 task
tsterbak added a commit that referenced this issue May 6, 2023
@tsterbak
Improve the addons installer progress bars and fix issues (#139)
540df59 
This PR adds:
- Should resolve: #103
- Wait for adb to become available at the right times.

Todo:
- [x] can the device interaction and waiting time be optimized?
@MagicLike
Copy link
Member Author

I am gonna keep this issue open, to leave the option to further investigate the adb problem described above.

@tsterbak tsterbak closed this as completed May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tsterbak @MagicLike