Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for OnePlusN200 #332

Closed
2 tasks done
Doomsdayrs opened this issue Oct 21, 2023 · 4 comments
Closed
2 tasks done

Add support for OnePlusN200 #332

Doomsdayrs opened this issue Oct 21, 2023 · 4 comments
Labels
device Request to add or improve a specific device.

Comments

@Doomsdayrs
Copy link

Is your device already requested?

  • I have searched the existing issues

Brand

OnePlus

Name

OnePlus N200 5G

Device code

OnePlusN200

Model

DE2117

Device images

- https://wiki.lineageos.org/devices/dre/

Do you own the device and would be willing to test the installer?

  • I own the device and am willing to test the installer on it.

Additional context

This seems to be a different device code?
@Doomsdayrs Doomsdayrs added the device Request to add or improve a specific device. label Oct 21, 2023
@MagicLike
Copy link
Member

This seems to be a different device code?

Seems like it - should be a relatively easy fix, but atm I am a bit busy... If it is urgent for you, I can show you how to apply the fix locally...

@MagicLike MagicLike added bug Something isn't working and removed bug Something isn't working labels Oct 22, 2023
@SirRGB
Copy link
Contributor

SirRGB commented Nov 21, 2023

OnePlusN200 is on the list for a while now, so is this resolved?

https://github.com/openandroidinstaller-dev/openandroidinstaller/blob/main/openandroidinstaller/assets/configs/dre.yaml#L8

@Doomsdayrs
Copy link
Author

It is a different device code, thus it doesn't get registered as the same device

@SirRGB
Copy link
Contributor

SirRGB commented Nov 22, 2023 •
edited
Loading

Ah, my bad, I misread
So just "OnePlusN200"? Ill add it so u can test.

So yea, I missed this in my assert commit, but it is in the lineage asserts, so it should just work in future versions.
https://github.com/LineageOS/android_device_oneplus_dre/blob/110bdcd8a72974f032746b71fd3865e484382739/BoardConfig.mk#L47

SirRGB added a commit to SirRGB/openandroidinstaller that referenced this issue Nov 22, 2023
@SirRGB
sync dre asserts
1ed2262 
* taken from https://github.com/LineageOS/android_device_oneplus_dre/blob/110bdcd8a72974f032746b71fd3865e484382739/BoardConfig.mk#L47
* fixes openandroidinstaller-dev#320 and openandroidinstaller-dev#332

Signed-off-by: SirRGB <sirrgb@proton.me>
@SirRGB SirRGB mentioned this issue Nov 22, 2023
Merged
SirRGB added a commit to SirRGB/openandroidinstaller that referenced this issue Nov 23, 2023
@SirRGB
sync dre asserts
5c3ba87 
* taken from https://github.com/LineageOS/android_device_oneplus_dre/blob/110bdcd8a72974f032746b71fd3865e484382739/BoardConfig.mk#L47
* fixes openandroidinstaller-dev#320 and openandroidinstaller-dev#332

Signed-off-by: SirRGB <sirrgb@proton.me>
tsterbak added a commit that referenced this issue Dec 10, 2023
@tsterbak
update misc asserts (#364)
793d50d 
Fixes
#375,
#332
and
#308
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
device Request to add or improve a specific device.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Doomsdayrs @SirRGB @MagicLike