Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show error details when selecting wrong image or recovery #354

Closed
julianfoad opened this issue Nov 11, 2023 · 1 comment · Fixed by #399
Closed

Show error details when selecting wrong image or recovery #354

julianfoad opened this issue Nov 11, 2023 · 1 comment · Fixed by #399
Labels
enhancement New feature or request

Comments

@julianfoad
Copy link

When selecting an image or recovery that does not match the device codes, I was bothered by the lack of transparency and specificity in the error message, which just said the files "don't work with the device".

We now show an error message that gives the user a better clue about why we rejected the file they chose. It explicitly shows the discovered and expected device codes.

For instance:

"This image lists support for device codes {supported_devices}. One of these should match one of your device's code names {supported_device_codes}."

For screen-shots see the issue in my own repository.

For the patch, you can review the diff of my branch against upstream dev branch (when I last synchronised it).

You can merge this into the dev branch of your fork using a standard git command (why not a github PR?):

git pull https://lab.trax.im/fork/github/openandroidinstaller-dev/openandroidinstaller.git 1-show-error-details-when-selecting-wrong-image-or-recovery
@tsterbak tsterbak added the enhancement New feature or request label Nov 22, 2023
@tsterbak
Copy link
Member

Thank you! I will have a look and move forward merging it :)

@tsterbak tsterbak linked a pull request Dec 25, 2023 that will close this issue
tsterbak added a commit that referenced this issue Jan 14, 2024
This PR mainly addresses #394 and #354.

It also adds:
- improved Makefile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants