Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to select LMODroid #416

Closed
SirRGB opened this issue Jan 11, 2024 · 6 comments
Closed

Unable to select LMODroid #416

SirRGB opened this issue Jan 11, 2024 · 6 comments
Labels
bug Something isn't working

Comments

@SirRGB
Copy link
Contributor

SirRGB commented Jan 11, 2024

Describe the bug
When trying to select the LMODroid-4.2-20240107-RELEASE-cheeseburger.zip package it simply doesnt work. Selecting the Lineage Package and then the LMO one does let you continue the process and still flashes the LMO package for some reason.

To Reproduce
Steps to reproduce the behavior:

  1. Connect device
  2. Fill requirement checkboxes
  3. Select lineage-20.0-20240108-nightly-cheeseburger-signed.zip
  4. Select LMODroid-4.2-20240107-RELEASE-cheeseburger.zip
  5. Continue normal process.

Expected behavior
Selecting LMO should not throw an error.

Log file
https://haste.aicp-rom.com/hixofimibe.sql

Desktop (please complete the following information):

  • OS: Tuxedo OS 2, based on Ubuntu 20.04 LTS

  • Version 0.52 dev, 379-resizingscaling-support

  • Smartphone (please complete the following information):

  • Device: OnePlus 5

  • OS: crDroid -> LMODroid

  • Version 9.12 -> 4.2

@SirRGB SirRGB added the bug Something isn't working label Jan 11, 2024
@SirRGB
Copy link
Contributor Author

SirRGB commented Jan 11, 2024

grafik

You can tick the checkboxes and untick them and it still satisfies the checks, so after all conditions are met all checks are disabled. Still doesnt explain the lmo bug (regex stuff ig), but could be helpful.

@anon1892
Copy link
Member

Can you provide a link to the file, please?

@SirRGB
Copy link
Contributor Author

SirRGB commented Jan 11, 2024

@anon1892
Copy link
Member

The fun fact is that I have no problem with LMODroid-4.2-20240107-RELEASE-cheeseburger.zip...
But I have found another problem with IMG-e-1.18-t-20231207360613-stable-FP5.zip (which can't be flashed by OAI because it's a very strange installation package)

tsterbak added a commit that referenced this issue Jan 15, 2024
Related to #416, but don't explain it.
This PR just handle a system image as invalid instead of crashing when :
- File is not a zip file (so like #416 )
- File is a zip file but does not contain metadata file

For now, only `IMG-e-1.18-t-20231207360613-stable-FP5.zip` is known to
be in the second case, and it's a very strange installation package, OAI
cannot handle that for now (related to #288 ?), so the file is shown as
invalid.
Maybe we can explain it with more details to the user?
@anon1892
Copy link
Member

Is this bug still present on the latest version? @SirRGB

@SirRGB
Copy link
Contributor Author

SirRGB commented Jan 24, 2024

No, I also couldnt replicate it in the version, that I thought I had the issue on. Ig I shouldve double-checked. The logs suggest, that I might not have chosen a zip.

grafik

You can tick the checkboxes and untick them and it still satisfies the checks, so after all conditions are met all checks are disabled. Still doesnt explain the lmo bug (regex stuff ig), but could be helpful.

This is still present though, but only visual, so I dont think it is important...

@SirRGB SirRGB closed this as completed Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants