Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue with device codes for OnePlus devices #48

Closed
tsterbak opened this issue Dec 29, 2022 · 1 comment
Closed

Issue with device codes for OnePlus devices #48

tsterbak opened this issue Dec 29, 2022 · 1 comment
Assignees
@tsterbak
Labels
bug Something isn't working device Request to add or improve a specific device.
Milestone
Release Alpha 0.3.2

Comments

@tsterbak
Copy link
Member

For (some) OnePlus devices the device code read by adb is the name of the device (guacamoleb -> OnePlus7).

Todo:

  • Figure out if this is the case in general.
  • Adapt the configs accordingly.
@tsterbak tsterbak self-assigned this Dec 29, 2022
@tsterbak tsterbak added bug Something isn't working device Request to add or improve a specific device. labels Dec 29, 2022
@tsterbak tsterbak added this to the Release Alpha 0.3.2 milestone Dec 29, 2022
@tsterbak
Copy link
Member Author

Patch the device codes like for yuga.

@tsterbak tsterbak mentioned this issue Dec 29, 2022
Merged
tsterbak added a commit that referenced this issue Jan 3, 2023
@tsterbak
New devices for release 0.3.2 (#49)
f3f7603 
This PR adds:
- fix for #48 

Support for new devices:
- Fairphone 4
- Samsung Galaxy Note 3 LTE (#46)
- Google Pixel 4 XL
- Google Pixel 3a XL (#38)
- Google Pixel 3 XL
- Google Pixel 3
- Google Pixel 2 XL
- Google Pixel 2
@tsterbak tsterbak mentioned this issue Jan 3, 2023
Merged
tsterbak added a commit that referenced this issue Jan 4, 2023
@tsterbak
Release v0.3.2-alpha (#50)
1c9a257 
This PR adds:
- a debug mode (addressing #27)
- basic tests for the full app
- Open Feedback page when finishing the install process
- fix for #48 

Support for new devices:
- Fairphone 4
- Samsung Galaxy Note 3 LTE (#46)
- Google Pixel 4 XL
- Google Pixel 3a XL (#38)
- Google Pixel 3 XL
- Google Pixel 3
- Google Pixel 2 XL
- Google Pixel 2
@tsterbak tsterbak closed this as completed Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsterbak tsterbak

Labels
bug Something isn't working device Request to add or improve a specific device.
Projects
None yet
Milestone
Release Alpha 0.3.2
Development

No branches or pull requests
1 participant
@tsterbak