Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for apollo #490

Open
2 tasks done
BKLronin opened this issue Mar 29, 2024 · 11 comments · Fixed by #493
Open
2 tasks done

Add support for apollo #490

BKLronin opened this issue Mar 29, 2024 · 11 comments · Fixed by #493
Labels
device Request to add or improve a specific device.

Comments

@BKLronin
Copy link

Is your device already requested?

  • I have searched the existing issues

Brand

Xiaomi

Name

Mi10 T PRO

Device code

apollo

Model

No response

Device images

https://download.lineageos.org/devices/apollon/builds

Do you own the device and would be willing to test the installer?

  • I own the device and am willing to test the installer on it.

Additional context

Needs to be unlocked by the manufacturer first but after that it would be nice to update with androidinstaller.
@BKLronin BKLronin added the device Request to add or improve a specific device. label Mar 29, 2024
@anon1892
Copy link
Member

Hello, thanks for your interest in this project!
I've just looked at LineageOS installation process and created a configuration file for this device. #493
Since it's not tested yet, could you help us by testing it please? We can help you if needed.

@anon1892 anon1892 linked a pull request Mar 30, 2024 that will close this issue
@BKLronin
Copy link
Author

Thank you for providing this. :)

I could try, Its my main phone so I need to be a bit careful. Iḿ already on Lineage 19.1 so things might work a little different.

Instructions would be good. Iḿ on manjaro or arm64 Sonoma mac.

@tsterbak
Copy link
Member

Hey, the installer will do a clean install with a factory reset, so you should backup everything you want to keep.
Besides from that, it will use TWRP to sideload the ROM, so usually it is basically impossible to brick the device if you know how to flash a recovery by cli if necessary.

The easiest way to test it is to use the linux executable and put the config file from the PR to the directory the executable is running from. The installer will pick this up and support your device. Alternatively, you could do the python setup with poetry and run the installer from there.

Let me know if you need any help :)

@BKLronin
Copy link
Author

I flashed manually yesterday as I dont want a factory reset.
If the internal updater cant patch to the next major version, would it make sense to add a second script that patches phones with already existing lineage oses installed?

@anon1892
Copy link
Member

I don't think so: if LOS team didn't allow Android versions changes directly from their updater, it's because it isn't without risk. The success of dirty flashing highly depends on the device and android version, and there is no data for this.

@BKLronin
Copy link
Author

It is the official strategy for an upgrade from say 19. to 20. https://wiki.lineageos.org/devices/apollon/upgrade/variant1/

Maybe a different technical reason why its not done from the internal updater.

If theres no checkbox for "already on lineage" the average user, this installer is aimed at, would be stuck.

@anon1892
Copy link
Member

This guide is supposed to work with LOS recovery, which is not currently supported by OpenAndroidInstaller (and probably not for a long time, since it does not support all adb shell twrp ... useful commands for scripting...
And I've heard many stories of dirty flash procedures that didn't work, I think it's risky to add it into OAI as a second script. But maybe we can add an option in the future "Advanced Mode" to not format data partition... What do you think @tsterbak ?

@BKLronin
Copy link
Author

Ah I see, didn't noticed the different recovery.

At least for this specific case I can report that flashing went successful without any losses.

@tsterbak
Copy link
Member

tsterbak commented Apr 5, 2024

And I've heard many stories of dirty flash procedures that didn't work, I think it's risky to add it into OAI as a second script. But maybe we can add an option in the future "Advanced Mode" to not format data partition... What do you think @tsterbak ?

@anon1892 I never do dirty flashes, since I had bad experiences with it and I don't think it is encouraged at all. But once we scope the "Advanced Mode", we could add an option to skip factory resets and partition wipes to enable dirty flashes.

At least for this specific case I can report that flashing went successful without any losses.

@BKLronin You mean dirty flashing, right?

Also, do you still see an option to test the config with your device? :)

@tsterbak
Copy link
Member

tsterbak commented Apr 5, 2024

You could open an Issue to request options to upgrade Android versions and/or dirty flash :) this way it is not lost in this device specific issue and I can add it to the road map.

@BKLronin
Copy link
Author

BKLronin commented Apr 7, 2024

Also, do you still see an option to test the config with your device? :)

I´m afraid not at the moment but I can offer to add devices in the future If I get a new one or lost device etc.
I´didn´t have in mind that it requires a wipe when adding the device on the wishlist.

I have a BV6000 that is free for testing but its not very popular or widespread.

tsterbak added a commit that referenced this issue May 14, 2024
This PR adds support for `apollo` / `apollon` (Xiaomi Mi 10T / 10T Pro /
Redmi K30S Ultra)
Asked in issue #490

@BKLronin : This is not tested for now, but it should work (same config
as #222 for instance)
Can you test it please? We can help you if needed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
device Request to add or improve a specific device.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants