Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for violet #516

Closed
2 tasks done
harshangithub opened this issue May 3, 2024 · 15 comments · Fixed by #517
Closed
2 tasks done

Add support for violet #516

harshangithub opened this issue May 3, 2024 · 15 comments · Fixed by #517
Labels
device Request to add or improve a specific device.

Comments

@harshangithub
Copy link

Is your device already requested?

  • I have searched the existing issues

Brand

Xiaomi Redmi

Name

Note 7 Pro

Device code

violet

Model

No response

Device images

No response

Do you own the device and would be willing to test the installer?

  • I own the device and am willing to test the installer on it.

Additional context

No response
@harshangithub harshangithub added the device Request to add or improve a specific device. label May 3, 2024
@anon1892 anon1892 mentioned this issue May 3, 2024
Merged
@anon1892
Copy link
Member

anon1892 commented May 3, 2024

I've just created the config file for violet : #517
Can you test it please?

@anon1892 anon1892 linked a pull request May 3, 2024 that will close this issue
Add support for violet (Redmi Note 7 Pro) #517
Merged
@harshangithub
Copy link
Author

harshangithub commented May 3, 2024 via email

@harshangithub
Copy link
Author

harshangithub commented May 3, 2024 via email

@anon1892
Copy link
Member

anon1892 commented May 3, 2024 •
edited
Loading

It's not yet updated, but it's easy : download latest OpenAndroidInstaller executable here (.exe on Windows for instance),
then place the configuration file I've created (download it here, with top right download icon) in the same directory as the executable. OpenAndroidInstaller should recognize the new config file.

@harshangithub
Copy link
Author

It works fine. But there are some issues where the ROM won't boot normally it always goes to the bootloader. I also noticed one spelling mistake in the program
--->In the first screen it is thought. spelling mistake: though

@anon1892
Copy link
Member

anon1892 commented May 5, 2024

The ROM won't boot normally it always goes to the bootloader.

Thank you for testing! So... It doesn't work for now... Which ROM & recovery did you tried?
I think it needs additional partitions to be flashed, like dtbo or so... Can you provide the installation documentation for the ROM you tried? And perhaps the logs or OpenAndroidInstaller, maybe an error was not handled as it should be? Thanks!

And thank you for reporting the spelling mistake!

@anon1892
Copy link
Member

anon1892 commented May 5, 2024

Uh, I think I've found the problem: additional partitions were asked but not flashed...
It's corrected with the last commit. Can you please download the latest config file here and try again? 🙏

@harshangithub
Copy link
Author

harshangithub commented May 6, 2024 via email

@harshangithub
Copy link
Author

harshangithub commented May 6, 2024 via email

@anon1892
Copy link
Member

anon1892 commented May 6, 2024

Nice, thank you for your help!

@anon1892
Copy link
Member

anon1892 commented May 6, 2024

Just to be sure, do you changed something else (like the ROM you flashed or so)?

@anon1892 anon1892 mentioned this issue May 6, 2024
Open
@harshangithub
Copy link
Author

harshangithub commented May 6, 2024 via email

@harshangithub
Copy link
Author

harshangithub commented May 6, 2024 via email

@anon1892
Copy link
Member

anon1892 commented May 6, 2024

Ok, thanks!

tsterbak added a commit that referenced this issue May 14, 2024
@tsterbak
Add support for violet (Redmi Note 7 Pro) (#517)
d9e66c7 
This PR adds support for `violet` (Xiaomi Redmi Note 7 Pro)
Asked in issue #516 

@harshangithub: This is not tested for now, but it should work (same
config as
#222
for instance)
Can you test it please? We can help you if needed.

EDIT: tested working!
@tsterbak
Copy link
Member

Merged now and will be part of the next release! Thanks a lot for your work folks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
device Request to add or improve a specific device.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for violet (Redmi Note 7 Pro) anon1892/oai
3 participants
@tsterbak @anon1892 @harshangithub