-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Samsung Galaxy J7 TMobile version #86
Comments
The selection list might be an interesting option 🤔 I decided to allow only exact matches, so people cannot just select something and totally wreck their phone. One option to try the tool for now is the following:
If that works fine for you, I can put the device code to the list of alternative device codes for "j7elte". 🙂 |
I am trying to test it, but running into another issue. This phone is quite old, and on the list of discontinued devices in LineageOS, so it's difficult to find a recent image for it. I picked a few and renamed with the correct device id, but the app does not like either of them:
I suspect there is something in the name I did not get right. |
Thank you for trying again! :) I suspect I know the issue. The installer tries to do some basic checks on the ROM image and the TWRP. For the ROM it basically checks if the device code is in the supported devices in the metadata of the image. You can find the metadata in |
I used this list to get the images:
https://www.getdroidtips.com/custom-rom-samsung-galaxy-j7/.
I changed the metadata and got a bit further, but it seems I ran into this
issue: Benjamin-Dobell/Heimdall#347.
I am attaching a log file for your reference.
…On Thu, Feb 23, 2023 at 12:43 PM Tobias Sterbak ***@***.***> wrote:
Thank you for trying again! :)
That looks good so far. Can you point me to where I can get one of the
images?
I suspect I know the issue. The installer tries to do some basic checks on
the ROM image and the TWRP. For the ROM it basically checks if the device
code is in the supported devices in the metadata of the image. You can find
the metadata in /META-INF/com/android/metadata in the zip file. The
supported devices are then listed under pre-device. If it's listed there,
you could send me the log file if you want, so I can further investigate
the issue. You can also share the config file you are currently using if
you want.
—
Reply to this email directly, view it on GitHub
<#86 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A44X62YKHOFV2KN4XLXDT4LWY6OTPANCNFSM6AAAAAAVEXY25E>
.
You are receiving this because you authored the thread.Message ID:
***@***.***
.com>
|
OT: I was considering my Samsung J5 to get some love at some point and the work on J7 might benefit also J5 devices (or maybe not) - firmwares for J5 are also on https://www.getdroidtips.com/custom-rom-galaxy-j5-2016/ (e.g. https://forum.xda-developers.com/t/blissroms-14-7-r-for-j5-2016-sm-j510x-vanilla-unofficial.4199195/ as I have SM-J510FN). |
Hm, that's curious, for the |
You could open a new issue for the J5 and if you want you can even start with the config of the J7, modify it (#86 (comment)) and try it with your device :) If that works well, you could open a PR with the new config. |
Fixed in #208 |
My phone is detected as j7eltetmo. I suspect it might be able to use the same config as j7elte. It would also be nice to have an option to choose from the list if the detection fails to match exactly.
The text was updated successfully, but these errors were encountered: