Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magisk support #92

Open
Gooberpatrol66 opened this issue Mar 1, 2023 · 7 comments
Open

Magisk support #92

Gooberpatrol66 opened this issue Mar 1, 2023 · 7 comments
Labels
enhancement New feature or request hacktoberfest help wanted Extra attention is needed question Further information is requested

Comments

@Gooberpatrol66
Copy link

Gooberpatrol66 commented Mar 1, 2023

Can this tool be used to more easily install Magisk on top of LineageOS (or other ROMs)?

@tsterbak
Copy link
Member

tsterbak commented Mar 2, 2023

Hey, thanks for your interest in the project! :)
I have only very limited experience with Magisk since I usually don't root and I'm not super aware of the installation process. Can Magisk be sideloaded as a flashable zip or need some other things need to be patched?

@tsterbak tsterbak added help wanted Extra attention is needed question Further information is requested labels Mar 2, 2023
@SirRGB
Copy link
Contributor

SirRGB commented Mar 2, 2023

yep, most people flash the apk or rename it to .zip and flash it (in case the twrp version is too old)
the recommended method is to patch the boot.img using the app, but no one really does that.

@anon1892
Copy link
Member

anon1892 commented Aug 2, 2023

Yes, flashing Magisk zip as "addon" works (used OrangeFox on lavender, see #218 and #222)

@MagicLike
Copy link
Member

I used the "app patches boot.img" way and it also worked fine...

@anon1892 Does the addon flashing also work for twrp or only for orangefox?

@anon1892
Copy link
Member

anon1892 commented Aug 2, 2023

zip flashing is not specific to OrangeFox (which is based on TWRP), so it should work

@Doctorlao
Copy link

操作不来啊蛋蛋

@MagicLike MagicLike added enhancement New feature or request hacktoberfest labels Oct 12, 2023
@SirRGB
Copy link
Contributor

SirRGB commented Jan 11, 2024

The first step is done and will be included in 0.52. Flashing magisk as addon still requires renaming the .apk to .zip or simply ignoring the .zip suffix when selecting the file.

6859a5e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hacktoberfest help wanted Extra attention is needed question Further information is requested
Projects
None yet
Development

No branches or pull requests

6 participants